Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 813363008: gn: declare use_debug_fission and use_gold as a build arguments (Closed)

Created:
5 years, 11 months ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: declare use_debug_fission and use_gold as a build arguments BUG=448159 Committed: https://crrev.com/cb33eb25aace2f181f2d785f4fd866fbab7f7c27 Cr-Commit-Position: refs/heads/master@{#311234}

Patch Set 1 : fix use_debug_fission comment #

Patch Set 2 : make use_gold and use_debug_fission build arguments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M build/config/compiler/BUILD.gn View 1 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@brettw: PTAL
5 years, 11 months ago (2015-01-12 22:43:57 UTC) #2
brettw
lgtm
5 years, 11 months ago (2015-01-13 02:27:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813363008/20001
5 years, 11 months ago (2015-01-13 06:53:11 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-13 07:48:40 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 07:49:24 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cb33eb25aace2f181f2d785f4fd866fbab7f7c27
Cr-Commit-Position: refs/heads/master@{#311234}

Powered by Google App Engine
This is Rietveld 408576698