Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Unified Diff: build/config/compiler/BUILD.gn

Issue 813363008: gn: declare use_debug_fission and use_gold as a build arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make use_gold and use_debug_fission build arguments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index dcd5d6596d619d40e2389f20f7fee94cdd351694..c61964fc86db552551b3dda4a440cdc891427f0a 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -33,17 +33,18 @@ declare_args() {
# information to analyze.
# Requires profiling to be set to true.
enable_full_stack_frames_for_profiling = false
-}
-use_gold = is_linux && cpu_arch == "x64"
+ # Use gold for linking on 64-bit Linux only (on 32-bit it runs out of
+ # address space, and it doesn't support cross-compiling).
+ use_gold = is_linux && cpu_arch == "x64"
-if (!is_win) {
- # linux_use_debug_fission: whether to use split DWARF debug info
+ # use_debug_fission: whether to use split DWARF debug info
# files. This can reduce link time significantly, but is incompatible
# with some utilities such as icecc and ccache. Requires gold and
# gcc >= 4.8 or clang.
# http://gcc.gnu.org/wiki/DebugFission
- use_debug_fission = use_gold && linux_use_bundled_binutils && !use_ccache
+ use_debug_fission =
+ !is_win && use_gold && linux_use_bundled_binutils && !use_ccache
}
# default_include_dirs ---------------------------------------------------------
@@ -310,8 +311,6 @@ config("compiler") {
ldflags += [ "-pthread" ]
}
if (use_gold) {
- # Use gold for linking on 64-bit Linux only (on 32-bit it runs out of
- # address space, and it doesn't support cross-compiling).
gold_path = rebase_path("//third_party/binutils/Linux_x64/Release/bin",
root_build_dir)
ldflags += [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698