runtime/vm/cha.cc - Issue 81333003: Do not eagerly finalize classes in CHA, instead regard unfinalized classes as ’non-existent’ an…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/cha.cc

Issue 81333003: Do not eagerly finalize classes in CHA, instead regard unfinalized classes as ’non-existent’ an… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/cha.cc

===================================================================

--- runtime/vm/cha.cc (revision 30540)

+++ runtime/vm/cha.cc (working copy)

@@ -83,7 +83,10 @@

Class& direct_subclass = Class::Handle();

for (intptr_t i = 0; i < cls_direct_subclasses.Length(); i++) {

direct_subclass ^= cls_direct_subclasses.At(i);

- if (direct_subclass.LookupDynamicFunction(function_name) !=

+ // Unfinalized classes are treated as non-existent for CHA purposes,

+ // as that means that no instance of that class exists at runtime.

+ if (direct_subclass.is_finalized() &&

+ direct_subclass.LookupDynamicFunction(function_name) !=

regis 2013/11/21 21:48:18 missing parenthesis

srdjan 2013/11/21 22:25:00 Done.

Function::null()) {

return true;

}

« no previous file with comments | « no previous file | runtime/vm/cha_test.cc » ('j') | runtime/vm/class_finalizer.cc » ('J')