Do not eagerly finalize classes in CHA, instead regard unfinalized classes as ’non-existent’ an…

runtime/vm/cha.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/cha.h"
 #include "vm/class_table.h"
 #include "vm/flags.h"
 #include "vm/freelist.h"
 #include "vm/object.h"
 #include "vm/raw_object.h"
@@ skipping 59 matching lines @@
 }
 
 
 bool CHA::HasOverride(const Class& cls, const String& function_name) {
   const GrowableObjectArray& cls_direct_subclasses =
       GrowableObjectArray::Handle(cls.direct_subclasses());
   // Subclasses of Object are not tracked by CHA. Safely assume that overrides
   // exist.
   if (cls.IsObjectClass()) return true;
 
   if (cls_direct_subclasses.IsNull()) {

[Ivan Posva, 2013/11/21 23:04:09]

We should initialize this with an empty array if necessary.

[srdjan, 2013/11/22 00:08:14]

direct_subclasses_ is of type GrowablObjectArray.

     return false;
   }
   Class& direct_subclass = Class::Handle();
   for (intptr_t i = 0; i < cls_direct_subclasses.Length(); i++) {
     direct_subclass ^= cls_direct_subclasses.At(i);
-    if (direct_subclass.LookupDynamicFunction(function_name) !=
+    // Unfinalized classes are treated as non-existent for CHA purposes,
+    // as that means that no instance of that class exists at runtime.
+    if (direct_subclass.is_finalized() &&
+        direct_subclass.LookupDynamicFunction(function_name) !=

[regis, 2013/11/21 21:48:18]

missing parenthesis

[srdjan, 2013/11/21 22:25:00]

Done.

         Function::null()) {
       return true;
     }
     if (HasOverride(direct_subclass, function_name)) {
       return true;
     }
   }
   return false;
 }
 
@@ skipping 23 matching lines @@
   ASSERT(!function.IsNull());
   ASSERT(function.IsDynamicFunction());
   const Class& function_owner = Class::Handle(function.Owner());
   const String& function_name = String::Handle(function.name());
   ZoneGrowableArray<intptr_t>* cids = new ZoneGrowableArray<intptr_t>();
   CollectSubclassIds(cids, function_owner);
   return GetNamedInstanceFunctionsOf(*cids, function_name);
 }
 
 }  // namespace dart