Source/core/animation/LengthPairStyleInterpolation.h - Issue 813233002: Animation: Fix loss of type information when interpolating value of 0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/LengthPairStyleInterpolation.h

Issue 813233002: Animation: Fix loss of type information when interpolating value of 0 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Attempt no2 at fixing linux oilpan errors Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/animation/DeferredLegacyStyleInterpolation.cpp ('K') | « Source/core/animation/LengthBoxStyleInterpolationTest.cpp ('k') | Source/core/animation/LengthPairStyleInterpolation.cpp » ('j') | Source/core/animation/LengthStyleInterpolation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/LengthPairStyleInterpolation.h

diff --git a/Source/core/animation/LengthPairStyleInterpolation.h b/Source/core/animation/LengthPairStyleInterpolation.h

index 18e2a280832df47f1dc6dea9bbd1ac8c7cc2dd04..e7b78eecfc3256b42565d7e7a7017b0260eb47a3 100644

--- a/Source/core/animation/LengthPairStyleInterpolation.h

+++ b/Source/core/animation/LengthPairStyleInterpolation.h

@@ -12,6 +12,7 @@ namespace blink {

class LengthPairStyleInterpolation : public StyleInterpolation {

public:

samli 2014/12/22 03:38:04 remove new line

static PassRefPtrWillBeRawPtr<LengthPairStyleInterpolation> create(const CSSValue& start, const CSSValue& end, CSSPropertyID id, ValueRange range)

{

return adoptRefWillBeNoop(new LengthPairStyleInterpolation(lengthPairToInterpolableValue(start), lengthPairToInterpolableValue(end), id, range));

@@ -20,6 +21,8 @@ public:

static bool canCreateFrom(const CSSValue&);

virtual void apply(StyleResolverState&) const override;

+ virtual void trace(Visitor*) override;

private:

LengthPairStyleInterpolation(PassOwnPtrWillBeRawPtr<InterpolableValue> start, PassOwnPtrWillBeRawPtr<InterpolableValue> end, CSSPropertyID id, ValueRange range)