Source/core/animation/DeferredLegacyStyleInterpolation.cpp - Issue 813233002: Animation: Fix loss of type information when interpolating value of 0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/DeferredLegacyStyleInterpolation.cpp

Issue 813233002: Animation: Fix loss of type information when interpolating value of 0 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Attempt no2 at fixing linux oilpan errors Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/DeferredLegacyStyleInterpolation.cpp

diff --git a/Source/core/animation/DeferredLegacyStyleInterpolation.cpp b/Source/core/animation/DeferredLegacyStyleInterpolation.cpp

index 633bde71ffc4205b506745da5baadd0ec4544dcd..e237c1695df3262cb7a98df659488ac78bba5769 100644

--- a/Source/core/animation/DeferredLegacyStyleInterpolation.cpp

+++ b/Source/core/animation/DeferredLegacyStyleInterpolation.cpp

@@ -58,7 +58,8 @@ bool DeferredLegacyStyleInterpolation::interpolationRequiresStyleResolve(const C

if (primitiveValue.isCalculated()) {

CSSLengthArray lengthArray(CSSPrimitiveValue::LengthUnitTypeCount);

- primitiveValue.accumulateLengthArray(lengthArray);

+ CSSLengthTypeArray lengthTypeArray(CSSPrimitiveValue::LengthUnitTypeCount);

+ primitiveValue.accumulateLengthArray(lengthArray, lengthTypeArray);

samli 2014/12/22 03:38:04 lengthTypeArray not used here

return lengthArray[CSSPrimitiveValue::UnitTypeFontSize] != 0

|| lengthArray[CSSPrimitiveValue::UnitTypeFontXSize] != 0

|| lengthArray[CSSPrimitiveValue::UnitTypeRootFontSize] != 0

« no previous file with comments | « no previous file | Source/core/animation/LengthBoxStyleInterpolationTest.cpp » ('j') | Source/core/animation/LengthPairStyleInterpolation.h » ('J')