Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 813233002: Animation: Fix loss of type information when interpolating value of 0 (Closed)

Created:
6 years ago by evemj (not active)
Modified:
6 years ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-reviews-css, rwlbuis, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Animation: Fix loss of type information when interpolating value of 0 Instead of returning 0px when a value of 0 is being interpolated regardless of type, LengthStyleInterpolation will return 0 of original unit type. Patch also fixes tests of LengthBoxStyleInterpolation, LengthPairStyleInterpolation and LengthStyleInterpolation to accommodate for this change. BUG=443850 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187639

Patch Set 1 #

Total comments: 3

Patch Set 2 : Attempt to fix linux oilpan errors #

Total comments: 2

Patch Set 3 : Attempt no2 at fixing linux oilpan errors #

Total comments: 20

Patch Set 4 : Removed changes to core.gypi, moved StringKeyframe, increased testing, added extra accumulate lengt… #

Total comments: 2

Patch Set 5 : Edit tests in LengthPointStyle3D #

Patch Set 6 : Fix second accumulateLength method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -54 lines) Patch
M Source/core/animation/LengthBoxStyleInterpolationTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/LengthPairStyleInterpolationTest.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/animation/LengthPoint3DStyleInterpolationTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/LengthStyleInterpolation.cpp View 1 2 3 4 chunks +38 lines, -22 lines 0 comments Download
M Source/core/animation/LengthStyleInterpolationTest.cpp View 1 2 3 3 chunks +69 lines, -12 lines 0 comments Download
M Source/core/css/CSSCalculationValue.h View 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSCalculationValue.cpp View 4 5 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.h View 1 2 3 4 5 3 chunks +5 lines, -0 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 2 3 4 5 1 chunk +14 lines, -3 lines 0 comments Download

Messages

Total messages: 23 (6 generated)
evemj (not active)
6 years ago (2014-12-19 03:05:28 UTC) #2
Eric Willigers
https://codereview.chromium.org/813233002/diff/1/Source/core/animation/LengthPairStyleInterpolation.cpp File Source/core/animation/LengthPairStyleInterpolation.cpp (right): https://codereview.chromium.org/813233002/diff/1/Source/core/animation/LengthPairStyleInterpolation.cpp#newcode38 Source/core/animation/LengthPairStyleInterpolation.cpp:38: RefPtr<CSSPrimitiveValue> first = toPrimitiveValue(LengthStyleInterpolation::interpolableValueToLength(lengthPair->get(0), range)); RefPtrWillBeRawPtr was better - ...
6 years ago (2014-12-19 03:16:30 UTC) #3
evemj (not active)
https://codereview.chromium.org/813233002/diff/1/Source/core/animation/LengthPairStyleInterpolation.cpp File Source/core/animation/LengthPairStyleInterpolation.cpp (right): https://codereview.chromium.org/813233002/diff/1/Source/core/animation/LengthPairStyleInterpolation.cpp#newcode38 Source/core/animation/LengthPairStyleInterpolation.cpp:38: RefPtr<CSSPrimitiveValue> first = toPrimitiveValue(LengthStyleInterpolation::interpolableValueToLength(lengthPair->get(0), range)); On 2014/12/19 03:16:29, Eric ...
6 years ago (2014-12-19 04:43:09 UTC) #4
Eric Willigers
https://codereview.chromium.org/813233002/diff/20001/Source/core/animation/StringKeyframe.cpp File Source/core/animation/StringKeyframe.cpp (right): https://codereview.chromium.org/813233002/diff/20001/Source/core/animation/StringKeyframe.cpp#newcode144 Source/core/animation/StringKeyframe.cpp:144: case CSSPropertyPerspectiveOrigin: PerspectiveOrigin can be negative: MDN - https://developer.mozilla.org/en-US/docs/Web/CSS/perspective-origin ...
6 years ago (2014-12-19 05:05:52 UTC) #5
mstensho (USE GERRIT)
6 years ago (2014-12-19 13:54:33 UTC) #6
evemj (not active)
https://codereview.chromium.org/813233002/diff/20001/Source/core/animation/StringKeyframe.cpp File Source/core/animation/StringKeyframe.cpp (right): https://codereview.chromium.org/813233002/diff/20001/Source/core/animation/StringKeyframe.cpp#newcode144 Source/core/animation/StringKeyframe.cpp:144: case CSSPropertyPerspectiveOrigin: On 2014/12/19 05:05:52, Eric Willigers wrote: > ...
6 years ago (2014-12-20 05:57:46 UTC) #7
Eric Willigers
lgtm https://codereview.chromium.org/813233002/diff/40001/Source/core/core.gypi File Source/core/core.gypi (right): https://codereview.chromium.org/813233002/diff/40001/Source/core/core.gypi#newcode1 Source/core/core.gypi:1: No need for the blank line to be ...
6 years ago (2014-12-22 00:49:20 UTC) #8
samli
Looks good so far. I think we can refactor this to make the change smaller. ...
6 years ago (2014-12-22 03:38:05 UTC) #9
evemj (not active)
https://codereview.chromium.org/813233002/diff/40001/Source/core/animation/LengthStyleInterpolation.cpp File Source/core/animation/LengthStyleInterpolation.cpp (right): https://codereview.chromium.org/813233002/diff/40001/Source/core/animation/LengthStyleInterpolation.cpp#newcode39 Source/core/animation/LengthStyleInterpolation.cpp:39: } On 2014/12/22 03:38:04, samli wrote: > Remove braces ...
6 years ago (2014-12-22 06:09:06 UTC) #10
samli
lgtm! Needs OWNERs approval https://codereview.chromium.org/813233002/diff/60001/Source/core/css/CSSPrimitiveValue.cpp File Source/core/css/CSSPrimitiveValue.cpp (right): https://codereview.chromium.org/813233002/diff/60001/Source/core/css/CSSPrimitiveValue.cpp#newcode686 Source/core/css/CSSPrimitiveValue.cpp:686: CSSLengthTypeArray zeroLengthTypeArray; lengthTypeArray is fine
6 years ago (2014-12-22 06:23:10 UTC) #11
evemj (not active)
https://codereview.chromium.org/813233002/diff/60001/Source/core/css/CSSPrimitiveValue.cpp File Source/core/css/CSSPrimitiveValue.cpp (right): https://codereview.chromium.org/813233002/diff/60001/Source/core/css/CSSPrimitiveValue.cpp#newcode686 Source/core/css/CSSPrimitiveValue.cpp:686: CSSLengthTypeArray zeroLengthTypeArray; On 2014/12/22 06:23:10, samli wrote: > lengthTypeArray ...
6 years ago (2014-12-22 23:05:15 UTC) #13
samli
6 years ago (2014-12-22 23:24:24 UTC) #15
haraken
oilpan part LGTM
6 years ago (2014-12-23 00:02:14 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813233002/100001
6 years ago (2014-12-23 00:34:03 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/39973)
6 years ago (2014-12-23 02:05:51 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813233002/120001
6 years ago (2014-12-23 06:34:44 UTC) #22
commit-bot: I haz the power
6 years ago (2014-12-23 09:00:24 UTC) #23
Message was sent while issue was closed. 
Committed patchset #6 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187639

Powered by Google App Engine
This is Rietveld 408576698