Animation: Fix loss of type information when interpolating value of 0

Source/core/css/parser/SizesCalcParserTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/css/parser/SizesCalcParser.h"
 
 #include "core/MediaTypeNames.h"
 #include "core/css/CSSPrimitiveValue.h"
 #include "core/css/MediaValuesCached.h"
@@ skipping 11 matching lines @@
     const bool dontRunInCSSCalc;
 };
 
 static void initLengthArray(CSSLengthArray& lengthArray)
 {
     lengthArray.resize(CSSPrimitiveValue::LengthUnitTypeCount);
     for (size_t i = 0; i < CSSPrimitiveValue::LengthUnitTypeCount; ++i)
         lengthArray.at(i) = 0;
 }
 
+static void initLengthTypeArray(CSSLengthTypeArray& lengthTypeArray)
+{
+    lengthTypeArray.resize(CSSPrimitiveValue::LengthUnitTypeCount);
+    for (size_t i = 0; i < CSSPrimitiveValue::LengthUnitTypeCount; ++i)
+        lengthTypeArray.clear(i);
+}
+
 static void verifyCSSCalc(String text, double value, bool valid, unsigned fontSize, unsigned viewportWidth, unsigned viewportHeight)
 {
     CSSLengthArray lengthArray;
     initLengthArray(lengthArray);
+    CSSLengthTypeArray lengthTypeArray;
+    initLengthTypeArray(lengthTypeArray);
     RefPtrWillBeRawPtr<CSSValue> cssValue = CSSParser::parseSingleValue(CSSPropertyLeft, text);
     CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(cssValue.get());
     if (primitiveValue)
-        primitiveValue->accumulateLengthArray(lengthArray);
+        primitiveValue->accumulateLengthArray(lengthArray, lengthTypeArray);

[samli, 2014/12/22 03:38:05]

Not actually used here, so we can remove it if we make the above change.

[evemj (not active), 2014/12/22 06:09:06]

Done.

     else
         ASSERT_EQ(valid, false);
     float length = lengthArray.at(CSSPrimitiveValue::UnitTypePixels);
     length += lengthArray.at(CSSPrimitiveValue::UnitTypeFontSize) * fontSize;
     length += lengthArray.at(CSSPrimitiveValue::UnitTypeViewportWidth) * viewportWidth / 100.0;
     length += lengthArray.at(CSSPrimitiveValue::UnitTypeViewportHeight) * viewportHeight / 100.0;
     ASSERT_EQ(value, length);
 }
 
 
@@ skipping 75 matching lines @@
     }
 
     for (unsigned i = 0; testCases[i].input; ++i) {
         if (testCases[i].dontRunInCSSCalc)
             continue;
         verifyCSSCalc(testCases[i].input, testCases[i].output, testCases[i].valid, data.defaultFontSize, data.viewportWidth, data.viewportHeight);
     }
 }
 
 } // namespace