Issue 813163007: Enable strict type checking for Selection.selectAllChildren()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 813163007: Enable strict type checking for Selection.selectAllChildren() (Closed)

Created:
6 years ago by philipj_slow

Modified:
6 years ago

Reviewers:
fs

CC:
blink-reviews, arv+blink, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Enable strict type checking for Selection.selectAllChildren() http://w3c.github.io/selection-api/#idl-def-Selection Firefox Nightly and IE11 also throws exceptions for the cases tested, making this change likely Web compatible. BUG=443721 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187538

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -9 lines)			Patch
M	LayoutTests/editing/selection/selectAllChildren.html	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/editing/selection/selectAllChildren-expected.txt	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/editing/DOMSelection.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/editing/Selection.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813163007/1

6 years ago (2014-12-19 13:40:48 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-19 14:52:09 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187538