Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: LayoutTests/editing/selection/selectAllChildren-expected.txt

Issue 813163007: Enable strict type checking for Selection.selectAllChildren() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/editing/selection/selectAllChildren.html ('k') | Source/core/editing/DOMSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/editing/selection/selectAllChildren-expected.txt
diff --git a/LayoutTests/editing/selection/selectAllChildren-expected.txt b/LayoutTests/editing/selection/selectAllChildren-expected.txt
index f12137f7f3c85a3048bca2b5c7713a0cb8ce5090..3e4681ecc7a1adb24ae3409967cd7f2140bc3a03 100644
--- a/LayoutTests/editing/selection/selectAllChildren-expected.txt
+++ b/LayoutTests/editing/selection/selectAllChildren-expected.txt
@@ -5,9 +5,9 @@ PASS s.focusNode is span1.firstChild
PASS s.focusOffset is 0
PASS window.getSelection().toString() is "foo"
PASS window.getSelection().toString() is "foobar"
-PASS s.selectAllChildren(null) did not throw exception.
-PASS s.selectAllChildren(window) did not throw exception.
-PASS s.selectAllChildren("") did not throw exception.
+PASS s.selectAllChildren(null) threw exception TypeError: Failed to execute 'selectAllChildren' on 'Selection': parameter 1 is not of type 'Node'..
+PASS s.selectAllChildren(window) threw exception TypeError: Failed to execute 'selectAllChildren' on 'Selection': parameter 1 is not of type 'Node'..
+PASS s.selectAllChildren("") threw exception TypeError: Failed to execute 'selectAllChildren' on 'Selection': parameter 1 is not of type 'Node'..
PASS successfullyParsed is true
TEST COMPLETE
« no previous file with comments | « LayoutTests/editing/selection/selectAllChildren.html ('k') | Source/core/editing/DOMSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698