Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2225)

Unified Diff: chrome/browser/profiles/profile_metrics.cc

Issue 813133003: New Profile metric for Auth Errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Headers cleanup Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/profile_metrics.cc
diff --git a/chrome/browser/profiles/profile_metrics.cc b/chrome/browser/profiles/profile_metrics.cc
index 0804fd88b8de1a4f9306faa0cec4e890e09404e1..180b9a7e5e6fbe74df469f5bef1279237995d7cf 100644
--- a/chrome/browser/profiles/profile_metrics.cc
+++ b/chrome/browser/profiles/profile_metrics.cc
@@ -139,6 +139,8 @@ bool ProfileMetrics::CountProfileInformation(ProfileManager* manager,
counts->signedin++;
if (info_cache.IsUsingGAIAPictureOfProfileAtIndex(i))
counts->gaia_icon++;
+ if (info_cache.ProfileIsAuthErrorAtIndex(i))
+ counts->auth_errors++;
}
}
}
@@ -178,6 +180,8 @@ void ProfileMetrics::LogNumberOfProfiles(ProfileManager* manager) {
counts.unused);
UMA_HISTOGRAM_COUNTS_100("Profile.NumberOfSignedInProfilesWithGAIAIcons",
counts.gaia_icon);
noms (inactive) 2015/01/08 21:49:04 nit: I'm not sure I like this name. At first glanc
Mike Lerman 2015/01/09 02:15:04 It almost reads like English! Might make it compre
+ UMA_HISTOGRAM_COUNTS_100("Profile.NumberOfProfileAuthErrors",
+ counts.auth_errors);
LogLockedProfileInformation(manager);
UpdateReportedOSProfileStatistics(counts.total, counts.signedin);

Powered by Google App Engine
This is Rietveld 408576698