New Profile metric for Auth Errors.

chrome/browser/profiles/profile_metrics.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_metrics.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 121 matching lines @@
   for (size_t i = 0; i < number_of_profiles; ++i) {
     if (!HasProfileAtIndexBeenActiveSince(info_cache, i, oldest)) {
       counts->unused++;
     } else {
       if (info_cache.ProfileIsSupervisedAtIndex(i))
         counts->supervised++;
       if (!info_cache.GetUserNameOfProfileAtIndex(i).empty()) {
         counts->signedin++;
         if (info_cache.IsUsingGAIAPictureOfProfileAtIndex(i))
           counts->gaia_icon++;
+        if (info_cache.ProfileIsAuthErrorAtIndex(i))
+          counts->auth_errors++;
       }
     }
   }
   return true;
 }
 
 
 void ProfileMetrics::UpdateReportedProfilesStatistics(ProfileManager* manager) {
   ProfileCounts counts;
   if (CountProfileInformation(manager, &counts)) {
@@ skipping 18 matching lines @@
   if (success) {
     UMA_HISTOGRAM_COUNTS_100("Profile.NumberOfManagedProfiles",
                              counts.supervised);
     UMA_HISTOGRAM_COUNTS_100("Profile.PercentageOfManagedProfiles",
                              100 * counts.supervised / counts.total);
     UMA_HISTOGRAM_COUNTS_100("Profile.NumberOfSignedInProfiles",
                              counts.signedin);
     UMA_HISTOGRAM_COUNTS_100("Profile.NumberOfUnusedProfiles",
                              counts.unused);
     UMA_HISTOGRAM_COUNTS_100("Profile.NumberOfSignedInProfilesWithGAIAIcons",
                              counts.gaia_icon);

[noms (inactive), 2015/01/08 21:49:04]

nit: I'm not sure I like this name. At first glance I thought it meant "Number
of auth errors for profile". I don't have a better one though. Maybe
NumberOfProfilesWithAuthErrors?

[Mike Lerman, 2015/01/09 02:15:04]

It almost reads like English! Might make it comprehensible!

Done.

+    UMA_HISTOGRAM_COUNTS_100("Profile.NumberOfProfileAuthErrors",
+                             counts.auth_errors);
 
     LogLockedProfileInformation(manager);
     UpdateReportedOSProfileStatistics(counts.total, counts.signedin);
   }
 }
 
 void ProfileMetrics::LogProfileAddNewUser(ProfileAdd metric) {
   DCHECK(metric < NUM_PROFILE_ADD_METRICS);
   UMA_HISTOGRAM_ENUMERATION("Profile.AddNewUser", metric,
                             NUM_PROFILE_ADD_METRICS);
@@ skipping 269 matching lines @@
   UMA_HISTOGRAM_ENUMERATION("Profile.SyncSignIn",
                             GetProfileType(profile_path),
                             NUM_PROFILE_TYPE_METRICS);
 }
 
 void ProfileMetrics::LogProfileUpdate(const base::FilePath& profile_path) {
   UMA_HISTOGRAM_ENUMERATION("Profile.Update",
                             GetProfileType(profile_path),
                             NUM_PROFILE_TYPE_METRICS);
 }