New Profile metric for Auth Errors.

chrome/test/base/testing_profile_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_BASE_TESTING_PROFILE_MANAGER_H_
 #define CHROME_TEST_BASE_TESTING_PROFILE_MANAGER_H_
 
 #include <map>
 #include <string>
 
@@ skipping 66 matching lines @@
   // Deletes a guest TestingProfile from the profile manager.
   void DeleteGuestProfile();
 
   // Deletes the cache instance. This is useful for testing that the cache is
   // properly persisting data.
   void DeleteProfileInfoCache();
 
   // Sets ProfileManager's logged_in state. This is only useful on ChromeOS.
   void SetLoggedIn(bool logged_in);
 
+  // Sets the last used profile; also sets the active time to now.
+  void UpdateLastUser(Profile* last_active);

[noms (inactive), 2014/12/19 19:33:01]

Bleh, this name doesn't really agree with the comment. How about something like
SetLastUsedProfile()?
(i know it's calling UpdateLastUser on the profile manager, but I don't think
that method is well named either)

[Mike Lerman, 2014/12/19 19:53:18]

I really think they should have the same name, since they're doing the same
thing and this is just exposing the ProfileManager's private call. Giving them
different names would be confusing.

If I'll rename them, then I'll rename both. I don't like SetLastUsedProfile
since the method does more than just set the LastUsedProfile in the LocalState,
it also updates the active time of the ProfileInfo Cache. How about
MarkProfileActive()?

You're just getting me back for the signin_metrics thing aren't you ;)

+
   // Helper accessors.
   const base::FilePath& profiles_dir();
   ProfileManager* profile_manager();
   ProfileInfoCache* profile_info_cache();
 
  private:
   typedef std::map<std::string, TestingProfile*> TestingProfilesMap;
 
   // Does the actual ASSERT-checked SetUp work. This function cannot have a
   // return value, so it sets the |called_set_up_| flag on success and that is
@@ skipping 15 matching lines @@
   // Weak reference to the profile manager.
   ProfileManager* profile_manager_;
 
   // Map of profile_name to TestingProfile* from CreateTestingProfile().
   TestingProfilesMap testing_profiles_;
 
   DISALLOW_COPY_AND_ASSIGN(TestingProfileManager);
 };
 
 #endif  // CHROME_TEST_BASE_TESTING_PROFILE_MANAGER_H_