Issue 813093004: Remove redundant "virtual" from BuildServiceInstanceFor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 813093004: Remove redundant "virtual" from BuildServiceInstanceFor (Closed)

Created:
6 years ago by dmichael (off chromium)

Modified:
6 years ago

Reviewers:
Ken Rockot(use gerrit already)

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove redundant "virtual" from BuildServiceInstanceFor Currently, the Clang style checker ignores templates. In order to turn it on, we first must fix latent style violations. This CL covers extensions/ BUG=441916 TBR=rockot Committed: https://crrev.com/1ebe36a78b4eaf3255e92230a9c39817213ef74c Cr-Commit-Position: refs/heads/master@{#309258}

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	extensions/browser/browser_context_keyed_api_factory.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813093004/1

6 years ago (2014-12-19 18:58:45 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-19 21:08:19 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1ebe36a78b4eaf3255e92230a9c39817213ef74c
Cr-Commit-Position: refs/heads/master@{#309258}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages