Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: extensions/browser/browser_context_keyed_api_factory.h

Issue 813093004: Remove redundant "virtual" from BuildServiceInstanceFor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_BROWSER_CONTEXT_KEYED_API_FACTORY_H_ 5 #ifndef EXTENSIONS_BROWSER_BROWSER_CONTEXT_KEYED_API_FACTORY_H_
6 #define EXTENSIONS_BROWSER_BROWSER_CONTEXT_KEYED_API_FACTORY_H_ 6 #define EXTENSIONS_BROWSER_BROWSER_CONTEXT_KEYED_API_FACTORY_H_
7 7
8 #include "components/keyed_service/content/browser_context_dependency_manager.h" 8 #include "components/keyed_service/content/browser_context_dependency_manager.h"
9 #include "components/keyed_service/content/browser_context_keyed_service_factory .h" 9 #include "components/keyed_service/content/browser_context_keyed_service_factory .h"
10 #include "components/keyed_service/core/keyed_service.h" 10 #include "components/keyed_service/core/keyed_service.h"
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
95 : BrowserContextKeyedServiceFactory( 95 : BrowserContextKeyedServiceFactory(
96 T::service_name(), 96 T::service_name(),
97 BrowserContextDependencyManager::GetInstance()) { 97 BrowserContextDependencyManager::GetInstance()) {
98 DeclareFactoryDependencies(); 98 DeclareFactoryDependencies();
99 } 99 }
100 100
101 virtual ~BrowserContextKeyedAPIFactory() {} 101 virtual ~BrowserContextKeyedAPIFactory() {}
102 102
103 private: 103 private:
104 // BrowserContextKeyedServiceFactory implementation. 104 // BrowserContextKeyedServiceFactory implementation.
105 virtual KeyedService* BuildServiceInstanceFor( 105 KeyedService* BuildServiceInstanceFor(
106 content::BrowserContext* context) const override { 106 content::BrowserContext* context) const override {
107 return new T(context); 107 return new T(context);
108 } 108 }
109 109
110 // BrowserContextKeyedBaseFactory implementation. 110 // BrowserContextKeyedBaseFactory implementation.
111 // These can be effectively overridden with template specializations. 111 // These can be effectively overridden with template specializations.
112 virtual content::BrowserContext* GetBrowserContextToUse( 112 virtual content::BrowserContext* GetBrowserContextToUse(
113 content::BrowserContext* context) const override { 113 content::BrowserContext* context) const override {
114 if (T::kServiceRedirectedInIncognito) 114 if (T::kServiceRedirectedInIncognito)
115 return ExtensionsBrowserClient::Get()->GetOriginalContext(context); 115 return ExtensionsBrowserClient::Get()->GetOriginalContext(context);
(...skipping 11 matching lines...) Expand all
127 virtual bool ServiceIsNULLWhileTesting() const override { 127 virtual bool ServiceIsNULLWhileTesting() const override {
128 return T::kServiceIsNULLWhileTesting; 128 return T::kServiceIsNULLWhileTesting;
129 } 129 }
130 130
131 DISALLOW_COPY_AND_ASSIGN(BrowserContextKeyedAPIFactory); 131 DISALLOW_COPY_AND_ASSIGN(BrowserContextKeyedAPIFactory);
132 }; 132 };
133 133
134 } // namespace extensions 134 } // namespace extensions
135 135
136 #endif // EXTENSIONS_BROWSER_BROWSER_CONTEXT_KEYED_API_FACTORY_H_ 136 #endif // EXTENSIONS_BROWSER_BROWSER_CONTEXT_KEYED_API_FACTORY_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698