Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 812873003: Clean up forward declarations in WebKit/Source (Closed)

Created:
6 years ago by zhaoze.zhou
Modified:
6 years ago
Reviewers:
tkent, pdr., rwlbuis
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, aandrey+blink_chromium.org, caseq+blink_chromium.org, malch+blink_chromium.org, blink-reviews-css, yurys+blink_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, loislo+blink_chromium.org, zoltan1, sof, lushnikov+blink_chromium.org, Dominik Röttsches, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, Nate Chapin, tyoshino+watch_chromium.org, blink-reviews-rendering, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clean up forward declarations in WebKit/Source These forward references are not needed anymore. After this patch, WebKit/Source has no unneeded forward references any more. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187416

Patch Set 1 #

Patch Set 2 : add more #

Patch Set 3 : style fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -40 lines) Patch
M Source/bindings/core/v8/Dictionary.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/WebGLAny.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSGradientValue.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSPathValue.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/FontFace.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/RuleFeature.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/parser/BisonCSSParser.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/resolver/ScopedStyleResolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/resolver/StyleResolver.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/AXObjectCache.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/RenderTreeBuilder.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/htmlediting.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/markup.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/AsyncCallStackTracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptManager.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/FrameLoader.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderQuote.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/xml/DocumentXSLT.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/xml/XMLSerializer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/beacon/NavigatorBeacon.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/fetch/FetchRequestData.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/fetch/Response.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/geolocation/Geolocation.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseContext.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/fonts/opentype/OpenTypeVerticalData.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/paint/DrawingRecorder.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
zhaoze.zhou
6 years ago (2014-12-17 22:24:45 UTC) #2
zhaoze.zhou
tkent@chromium.org: can you take a look? thanks very much :)
6 years ago (2014-12-17 23:02:52 UTC) #4
rwlbuis
On 2014/12/17 23:02:52, zhaoze.zhou wrote: > mailto:tkent@chromium.org: can you take a look? thanks very much ...
6 years ago (2014-12-17 23:31:28 UTC) #6
zhaoze.zhou
On 2014/12/17 23:31:28, rwlbuis wrote: > On 2014/12/17 23:02:52, zhaoze.zhou wrote: > > mailto:tkent@chromium.org: can ...
6 years ago (2014-12-17 23:54:36 UTC) #7
pdr.
LGTM assuming the bots are happy. Which tool did you use to generate this? It ...
6 years ago (2014-12-17 23:56:33 UTC) #8
zhaoze.zhou
On 2014/12/17 23:56:33, pdr wrote: > LGTM assuming the bots are happy. > > Which ...
6 years ago (2014-12-18 00:00:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812873003/40001
6 years ago (2014-12-18 00:01:28 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-18 01:59:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187416

Powered by Google App Engine
This is Rietveld 408576698