components/infobars.gypi - Issue 812823002: Remove dependency of infobars component on the embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/infobars.gypi

Issue 812823002: Remove dependency of infobars component on the embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests by instanciating a TestConfirmInfoBarDelegateFactory Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/geolocation/geolocation_permission_context_unittest.cc ('K') | « components/google/core/browser/google_url_tracker_unittest.cc ('k') | components/infobars/core/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/infobars.gypi

diff --git a/components/infobars.gypi b/components/infobars.gypi

index ad13b70d5a6abb97ecf02a8d2d694399db160fde..3fd3c4e049807090cea68702be5afa63f9d5db16 100644

--- a/components/infobars.gypi

+++ b/components/infobars.gypi

@@ -25,6 +25,8 @@

# Note: sources duplicated in GN build.

'infobars/core/confirm_infobar_delegate.cc',

'infobars/core/confirm_infobar_delegate.h',

+ 'infobars/core/confirm_infobar_delegate_factory.cc',

+ 'infobars/core/confirm_infobar_delegate_factory.h',

'infobars/core/infobar.cc',

'infobars/core/infobar.h',

'infobars/core/infobar_container.cc',

@@ -50,7 +52,8 @@

'sources': [

# Note: sources list duplicated in GN build.

- 'infobars/test/infobar_test.cc',

+ 'infobars/test/test_confirm_infobar_delegate_factory.cc',

+ 'infobars/test/test_confirm_infobar_delegate_factory.h',