chrome/browser/geolocation/geolocation_permission_context_unittest.cc - Issue 812823002: Remove dependency of infobars component on the embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_permission_context_unittest.cc

Issue 812823002: Remove dependency of infobars component on the embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests by instanciating a TestConfirmInfoBarDelegateFactory Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/permission_queue_controller_unittest.cc ('k') | chrome/browser/infobars/chrome_confirm_infobar_delegate_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_permission_context_unittest.cc

diff --git a/chrome/browser/geolocation/geolocation_permission_context_unittest.cc b/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

index 282a808928adc7823d816b2a8a4ac551b22c6589..51fc3129d4637fed54fef216046da7803b35933a 100644

--- a/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

+++ b/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

@@ -25,6 +25,7 @@

#include "components/content_settings/core/common/permission_request_id.h"

#include "components/infobars/core/confirm_infobar_delegate.h"

#include "components/infobars/core/infobar.h"

+#include "components/infobars/test/test_confirm_infobar_delegate_factory.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/navigation_details.h"

#include "content/public/browser/notification_observer.h"

@@ -136,6 +137,7 @@ class GeolocationPermissionContextTests

GeolocationPermissionContext* geolocation_permission_context_;

ClosedInfoBarTracker closed_infobar_tracker_;

ScopedVector<content::WebContents> extra_tabs_;

+ TestConfirmInfoBarDelegateFactory confirm_info_bar_delegate_factory_;

Michael van Ouwerkerk 2014/12/17 19:23:43 Why is this needed? It appears to be unused.

sdefresne 2014/12/18 14:48:59 The TestConfirmInfoBarDelegateFactory used to do w

// A map between renderer child id and a pair represending the bridge id and

// whether the requested permission was allowed.