chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm - Issue 812823002: Remove dependency of infobars component on the embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm

Issue 812823002: Remove dependency of infobars component on the embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests by instanciating a TestConfirmInfoBarDelegateFactory Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/geolocation/geolocation_permission_context_unittest.cc ('K') | « chrome/browser/ui/android/infobars/confirm_infobar.cc ('k') | chrome/browser/ui/startup/session_crashed_infobar_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm

diff --git a/chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm b/chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm

index b541175fe139d5faee5c1da461c4279cd037c3e0..e096cdf0a4547c9bad9b2d1a65135be6497c67e2 100644

--- a/chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm

+++ b/chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm

@@ -6,6 +6,7 @@

#include "base/logging.h"

#include "base/strings/sys_string_conversions.h"

+#include "chrome/browser/infobars/chrome_confirm_infobar_delegate_factory.h"

#include "chrome/browser/ui/cocoa/infobars/infobar_cocoa.h"

#include "components/infobars/core/confirm_infobar_delegate.h"

#include "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h"

@@ -137,8 +138,8 @@

@end

-// static

-scoped_ptr<infobars::InfoBar> ConfirmInfoBarDelegate::CreateInfoBar(

+scoped_ptr<infobars::InfoBar>

+ChromeConfirmInfoBarDelegateFactory::CreateInfoBar(

scoped_ptr<ConfirmInfoBarDelegate> delegate) {

scoped_ptr<InfoBarCocoa> infobar(new InfoBarCocoa(delegate.Pass()));

base::scoped_nsobject<ConfirmInfoBarController> controller(

@@ -146,3 +147,4 @@ scoped_ptr<infobars::InfoBar> ConfirmInfoBarDelegate::CreateInfoBar(

infobar->set_controller(controller);

return infobar.Pass();

}