components/BUILD.gn - Issue 812823002: Remove dependency of infobars component on the embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/BUILD.gn

Issue 812823002: Remove dependency of infobars component on the embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix android compilation Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/keystone_infobar_delegate.mm ('K') | « chrome/browser/ui/website_settings/website_settings_infobar_delegate.cc ('k') | components/components_tests.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/BUILD.gn

diff --git a/components/BUILD.gn b/components/BUILD.gn

index ca0a8c265d0536339e93c6d35a0bb8bc683d187d..ce9b42d2018003f1ac18ceecf31b82fbbc40ac04 100644

--- a/components/BUILD.gn

+++ b/components/BUILD.gn

@@ -45,7 +45,6 @@ group("all_components") {

"//components/history/core/common",

"//components/history/core/test",

"//components/infobars/core",

- "//components/infobars/test:test_support",

"//components/invalidation",

"//components/json_schema",

"//components/keyed_service/content",

@@ -158,7 +157,6 @@ group("all_components") {

"//components/history/core/common", # Should work, needs checking.

"//components/history/core/test", # Should work, needs checking.

"//components/infobars/core", # Should work, needs checking.

- "//components/infobars/test:test_support", # Should work, needs checking.

"//components/invalidation", # Should work, needs checking.

"//components/json_schema", # Should work, needs checking.

"//components/keyed_service/content", # Blocked on content.