chrome/browser/ui/cocoa/keystone_infobar_delegate.mm - Issue 812823002: Remove dependency of infobars component on the embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/keystone_infobar_delegate.mm

Issue 812823002: Remove dependency of infobars component on the embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix android compilation Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/plugins/plugin_infobar_delegates.cc ('K') | « chrome/browser/ui/cocoa/infobars/confirm_infobar_controller.mm ('k') | chrome/browser/ui/collected_cookies_infobar_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/keystone_infobar_delegate.mm

diff --git a/chrome/browser/ui/cocoa/keystone_infobar_delegate.mm b/chrome/browser/ui/cocoa/keystone_infobar_delegate.mm

index afe31435e8d0aa847b7d5b435f69920e4fb3eab1..459517416b787bf3017c373bf29e09718a01c5cb 100644

--- a/chrome/browser/ui/cocoa/keystone_infobar_delegate.mm

+++ b/chrome/browser/ui/cocoa/keystone_infobar_delegate.mm

@@ -81,10 +81,10 @@ void KeystonePromotionInfoBarDelegate::Create() {

return;

InfoBarService* infobar_service =

InfoBarService::FromWebContents(webContents);

- infobar_service->AddInfoBar(ConfirmInfoBarDelegate::CreateInfoBar(

+ infobar_service->AddInfoBar(infobar_service->CreateConfirmInfoBar(

scoped_ptr<ConfirmInfoBarDelegate>(new KeystonePromotionInfoBarDelegate(

- Profile::FromBrowserContext(

- webContents->GetBrowserContext())->GetPrefs()))));

+ Profile::FromBrowserContext(webContents->GetBrowserContext())

+ ->GetPrefs()))));

Peter Kasting 2014/12/19 23:06:23 Nit: Old linebreaking here was better

sdefresne 2014/12/20 11:30:55 Sorry, I reformatted everything with clang-format

}

KeystonePromotionInfoBarDelegate::KeystonePromotionInfoBarDelegate(