Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5233)

Unified Diff: chrome/browser/chromeos/login/ui/login_web_dialog.h

Issue 812763003: Fix browser launch on the login screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Block new window popups on login screen. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/ui/login_web_dialog.h
diff --git a/chrome/browser/chromeos/login/ui/login_web_dialog.h b/chrome/browser/chromeos/login/ui/login_web_dialog.h
index c9d38cd5c2849259df8bd40c41de6cde8d114aa2..b6c20e2b9fdb6e4d15fff8f2e3c85c476ae5c1bf 100644
--- a/chrome/browser/chromeos/login/ui/login_web_dialog.h
+++ b/chrome/browser/chromeos/login/ui/login_web_dialog.h
@@ -83,6 +83,19 @@ class LoginWebDialog : public ui::WebDialogDelegate,
virtual bool ShouldShowDialogTitle() const override;
virtual bool HandleContextMenu(
const content::ContextMenuParams& params) override;
+ virtual bool HandleOpenURLFromTab(
dzhioev (left Google) 2014/12/22 18:30:13 Is this method still needed?
Ivan Podogov 2014/12/23 06:54:51 Yes, so that we could suppress OpenURL message ori
dzhioev (left Google) 2014/12/23 14:34:25 I'm not quiet sure if such behaviour is correct. L
+ content::WebContents* source,
+ const content::OpenURLParams& params,
+ content::WebContents** out_new_contents) override;
+ virtual bool HandleShouldCreateWebContents(
+ content::WebContents* web_contents,
+ int route_id,
+ int main_frame_route_id,
+ WindowContainerType window_container_type,
+ const base::string16& frame_name,
+ const GURL& target_url,
+ const std::string& partition_id,
+ content::SessionStorageNamespace* session_storage_namespace) override;
// content::NotificationObserver implementation.
virtual void Observe(int type,
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/ui/login_web_dialog.cc » ('j') | ui/web_dialogs/web_dialog_delegate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698