Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: chrome/browser/chromeos/login/ui/login_web_dialog.h

Issue 812763003: Fix browser launch on the login screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Block new window popups on login screen. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_UI_LOGIN_WEB_DIALOG_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_UI_LOGIN_WEB_DIALOG_H_
6 #define CHROME_BROWSER_CHROMEOS_LOGIN_UI_LOGIN_WEB_DIALOG_H_ 6 #define CHROME_BROWSER_CHROMEOS_LOGIN_UI_LOGIN_WEB_DIALOG_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 virtual void OnDialogShown( 76 virtual void OnDialogShown(
77 content::WebUI* webui, 77 content::WebUI* webui,
78 content::RenderViewHost* render_view_host) override; 78 content::RenderViewHost* render_view_host) override;
79 // NOTE: This function deletes this object at the end. 79 // NOTE: This function deletes this object at the end.
80 virtual void OnDialogClosed(const std::string& json_retval) override; 80 virtual void OnDialogClosed(const std::string& json_retval) override;
81 virtual void OnCloseContents( 81 virtual void OnCloseContents(
82 content::WebContents* source, bool* out_close_dialog) override; 82 content::WebContents* source, bool* out_close_dialog) override;
83 virtual bool ShouldShowDialogTitle() const override; 83 virtual bool ShouldShowDialogTitle() const override;
84 virtual bool HandleContextMenu( 84 virtual bool HandleContextMenu(
85 const content::ContextMenuParams& params) override; 85 const content::ContextMenuParams& params) override;
86 virtual bool HandleOpenURLFromTab(
dzhioev (left Google) 2014/12/22 18:30:13 Is this method still needed?
Ivan Podogov 2014/12/23 06:54:51 Yes, so that we could suppress OpenURL message ori
dzhioev (left Google) 2014/12/23 14:34:25 I'm not quiet sure if such behaviour is correct. L
87 content::WebContents* source,
88 const content::OpenURLParams& params,
89 content::WebContents** out_new_contents) override;
90 virtual bool HandleShouldCreateWebContents(
91 content::WebContents* web_contents,
92 int route_id,
93 int main_frame_route_id,
94 WindowContainerType window_container_type,
95 const base::string16& frame_name,
96 const GURL& target_url,
97 const std::string& partition_id,
98 content::SessionStorageNamespace* session_storage_namespace) override;
86 99
87 // content::NotificationObserver implementation. 100 // content::NotificationObserver implementation.
88 virtual void Observe(int type, 101 virtual void Observe(int type,
89 const content::NotificationSource& source, 102 const content::NotificationSource& source,
90 const content::NotificationDetails& details) override; 103 const content::NotificationDetails& details) override;
91 104
92 private: 105 private:
93 content::BrowserContext* browser_context_; 106 content::BrowserContext* browser_context_;
94 gfx::NativeWindow parent_window_; 107 gfx::NativeWindow parent_window_;
95 // Notifications receiver. 108 // Notifications receiver.
96 Delegate* delegate_; 109 Delegate* delegate_;
97 110
98 base::string16 title_; 111 base::string16 title_;
99 GURL url_; 112 GURL url_;
100 content::NotificationRegistrar notification_registrar_; 113 content::NotificationRegistrar notification_registrar_;
101 bool is_open_; 114 bool is_open_;
102 115
103 // Dialog display size. 116 // Dialog display size.
104 int width_; 117 int width_;
105 int height_; 118 int height_;
106 119
107 DISALLOW_COPY_AND_ASSIGN(LoginWebDialog); 120 DISALLOW_COPY_AND_ASSIGN(LoginWebDialog);
108 }; 121 };
109 122
110 } // namespace chromeos 123 } // namespace chromeos
111 124
112 #endif // CHROME_BROWSER_CHROMEOS_LOGIN_UI_LOGIN_WEB_DIALOG_H_ 125 #endif // CHROME_BROWSER_CHROMEOS_LOGIN_UI_LOGIN_WEB_DIALOG_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/login/ui/login_web_dialog.cc » ('j') | ui/web_dialogs/web_dialog_delegate.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698