Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 812603003: Fixed cube.js demo imports (Closed)

Created:
6 years ago by hansmuller
Modified:
5 years, 11 months ago
Reviewers:
blundell
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fixed cube.js demo imports The examples/js/cube.js application's import list was scrambled a bit by https://codereview.chromium.org/788343002. TBR=blundell@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/c853f650cabc661dca36a249a90fa6501937faf0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M examples/js/cube.js View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
hansmuller
Committed patchset #1 (id:1) manually as c853f650cabc661dca36a249a90fa6501937faf0 (presubmit successful).
6 years ago (2014-12-16 17:58:34 UTC) #2
blundell
The purpose of my reordering was to keep them in alphabetical order. Is the ordering ...
5 years, 11 months ago (2015-01-05 07:14:16 UTC) #3
hansmuller1
On 2015/01/05 07:14:16, blundell wrote: > The purpose of my reordering was to keep them ...
5 years, 11 months ago (2015-01-05 17:54:56 UTC) #4
blundell
5 years, 11 months ago (2015-01-06 06:49:55 UTC) #5
Message was sent while issue was closed. 
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698