Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Issue 788343002: Restructure public side of gpu service. (Closed)

Created:
6 years ago by blundell
Modified:
6 years ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Restructure public side of gpu service. This CL goes from this: //mojo/services/public/interfaces/gpu to this: //mojo/services/gpu/public/interfaces This CL also makes the Mojo-side changes necessary to roll this change into Chromium. TBR=beng Committed: https://chromium.googlesource.com/external/mojo/+/ecff1e72c1bb2eed0672c18f0132675b7ea78b84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -201 lines) Patch
M examples/bitmap_uploader/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/bitmap_uploader/bitmap_uploader.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/ganesh_app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M examples/js/cube.js View 1 chunk +3 lines, -3 lines 0 comments Download
M examples/sample_app/sample_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/surfaces_app/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M examples/surfaces_app/child_gl_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/surfaces_app/surfaces_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/aura/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/aura/surface_binding.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gles2/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gpu/gl_context.cc View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/gpu/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/gpu/public/interfaces/command_buffer.mojom View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/services/gpu/public/interfaces/gpu.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/services/gpu/public/interfaces/gpu_capabilities.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/services/gpu/public/interfaces/viewport_parameter_listener.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/services/native_viewport/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/native_viewport/public/interfaces/native_viewport.mojom View 1 chunk +1 line, -1 line 0 comments Download
D mojo/services/public/interfaces/gpu/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D mojo/services/public/interfaces/gpu/command_buffer.mojom View 1 chunk +0 lines, -53 lines 0 comments Download
D mojo/services/public/interfaces/gpu/gpu.mojom View 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/services/public/interfaces/gpu/gpu_capabilities.mojom View 1 chunk +0 lines, -54 lines 0 comments Download
D mojo/services/public/interfaces/gpu/viewport_parameter_listener.mojom View 1 chunk +0 lines, -12 lines 0 comments Download
M mojo/services/public/mojo_services_public.gyp View 1 chunk +5 lines, -5 lines 0 comments Download
M mojo/services/surfaces/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/surfaces/public/interfaces/surfaces.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/tools/roll/rev_sdk.py View 1 chunk +1 line, -0 lines 0 comments Download
M services/gles2/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M services/gles2/command_buffer_driver.h View 1 chunk +1 line, -1 line 0 comments Download
M services/gles2/command_buffer_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/gles2/command_buffer_type_conversions.h View 1 chunk +1 line, -1 line 0 comments Download
M services/gles2/command_buffer_type_conversions.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/gles2/gpu_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/native_viewport/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/native_viewport/native_viewport_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/native_viewport/viewport_surface.h View 1 chunk +1 line, -1 line 0 comments Download
M services/surfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/surfaces/surfaces_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M services/view_manager/display_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M sky/viewer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
blundell
are we having fun yet?
6 years ago (2014-12-10 21:15:56 UTC) #1
blundell
Committed patchset #1 (id:1) manually as ecff1e72c1bb2eed0672c18f0132675b7ea78b84 (presubmit successful).
6 years ago (2014-12-10 21:16:17 UTC) #2
Ben Goodger (Google)
6 years ago (2014-12-10 21:27:52 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698