Issue 812573006: Sky should symbolize pprof traces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 812573006: Sky should symbolize pprof traces (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, esprehn

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Sky should symbolize pprof traces In order for pprof to find the symbols in the profile, we need to rename the binaries from foo.mojo to libfoo_library.so. This CL adds that step to the stop_profiling command in skydb. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/876cd3e657c1986a298fbac10d8cd0fefeca08af

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
	M	sky/tools/debugger/prompt/prompt.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	sky/tools/skydb	View		2 chunks	+14 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 11 months ago (2015-01-20 22:27:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
876cd3e657c1986a298fbac10d8cd0fefeca08af (presubmit successful).