Sky should symbolize pprof traces

sky/tools/skydb

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from skypy.skyserver import SkyServer
 import argparse
 import json
 import logging
 import os
@@ skipping 302 matching lines @@
         if not urlparse.urlparse(args.url_or_path).scheme:
             # The load happens on the remote device, use the remote port.
             remote_sky_server_port = self.pids.get('remote_sky_server_port',
                 self.pids['sky_server_port'])
             url = SkyServer.url_for_path(remote_sky_server_port,
                     self.pids['sky_server_root'], args.url_or_path)
         else:
             url = args.url_or_path
         self._send_command_to_sky('/load', url)
 
+    def stop_profiling_command(self, args):
+        self._send_command_to_sky('/stop_profiling')
+        # We need to munge the profile to replace foo.mojo with libfoo.so so
+        # that pprof knows this represents an SO.
+        with open("sky_viewer.pprof", "r+") as profile_file:
+            data = profile_file.read()
+            profile_file.seek(0)
+            profile_file.write(re.sub(r'(\w+)\.mojo', r'lib\1_library.so', data))
+            profile_file.truncate()
+
     def _command_base_url(self):
         return 'http://localhost:%s' % self.pids['sky_command_port']
 
     def _send_command_to_sky(self, command_path, payload=None):
         url = 'http://localhost:%s%s' % (
             self.pids['sky_command_port'], command_path)
         if payload:
             response = requests.post(url, payload)
         else:
             response = requests.get(url)
@@ skipping 167 matching lines @@
         gdb_attach_parser.set_defaults(func=self.gdb_attach_command)
 
         self._add_basic_command(subparsers, 'trace', '/trace',
             'toggle tracing')
         self._add_basic_command(subparsers, 'reload', '/reload',
             'reload the current page')
         self._add_basic_command(subparsers, 'inspect', '/inspect',
             'stop the running sky instance')
         self._add_basic_command(subparsers, 'start_profiling', '/start_profiling',
             'starts profiling the running sky instance (Linux only)')
-        self._add_basic_command(subparsers, 'stop_profiling', '/stop_profiling',
-            'stios profiling the running sky instance (Linux only)')
+
+        stop_profiling_parser = subparsers.add_parser('stop_profiling',
+            help='stops profiling the running sky instance (Linux only)')
+        stop_profiling_parser.set_defaults(func=self.stop_profiling_command)
 
         load_parser = subparsers.add_parser('load',
             help='load a new page in the currently running sky')
         load_parser.add_argument('url_or_path', type=str)
         load_parser.set_defaults(func=self.load_command)
 
         args = parser.parse_args()
         args.func(args)
 
         self._write_pid_file(PID_FILE_PATH, self.pids)
 
 
 if __name__ == '__main__':
     SkyDebugger().main()