Issue 811963003: Revert of TableCaptionElement is not exposed to accessibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 811963003: Revert of TableCaptionElement is not exposed to accessibility (Closed)

Created:
6 years ago by vivekg

Modified:
6 years ago

Reviewers:
ramya.v, dmazzoni, aboxhall

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Revert of TableCaptionElement is not exposed to accessibility (patchset #2 id:20001 of https://codereview.chromium.org/812243004/) Reason for revert: This causes content_browsertests failures: DumpAccessibilityTreeTest.AccessibilityCaption http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/17483/steps/content_browsertests%20%28with%20patch%29/logs/AccessibilityCaption Original issue's description: > TableCaptionElement is not exposed to accessibility > > Adding caption element to accessibility tree. > > BUG=443970 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187641 TBR=dmazzoni@chromium.org,aboxhall@chromium.org,ramya.v@samsung.com NOTREECHECKS=true NOTRY=true BUG=443970 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187664

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -55 lines)			Patch
D	LayoutTests/accessibility/table-caption.html	View	1 chunk	+0 lines, -35 lines	0 comments	Download
D	LayoutTests/accessibility/table-caption-expected.txt	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	Source/modules/accessibility/AXTable.cpp	View	1 chunk	+0 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

vivekg

Created Revert of TableCaptionElement is not exposed to accessibility

6 years ago (2014-12-23 22:35:26 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811963003/1

6 years ago (2014-12-23 22:35:43 UTC) #2

commit-bot: I haz the power

6 years ago (2014-12-23 22:36:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187664