Define step timing function for the cc animation framework.

Define step timing function for the cc animation framework.

This is a blink-side part.
See the chromium part here: https://codereview.chromium.org/809523004

BUG=441006
R=dstockwell@chromium.org
R=ajuma@chromium.org
R=vollick@chromium.org
TEST=ManualTests/animation/compositor-animation-steps.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187891

[dstockwell, 2014-12-19 02:00:56]

https://codereview.chromium.org/812013002/diff/1/ManualTests/animation/compos...
File ManualTests/animation/compositor-animation-steps.html (right):

https://codereview.chromium.org/812013002/diff/1/ManualTests/animation/compos...
ManualTests/animation/compositor-animation-steps.html:32: var transformKeyframes
= [
nit: no need to indent this script

https://codereview.chromium.org/812013002/diff/1/Source/core/animation/Compos...
File Source/core/animation/CompositorAnimations.cpp (right):

https://codereview.chromium.org/812013002/diff/1/Source/core/animation/Compos...
Source/core/animation/CompositorAnimations.cpp:182: if
(timing.timingFunction->type() == TimingFunction::StepsFunction)
I think this isn't quite right, as the comment below indicates that the
combining of timing functions is only supported when there are 2 keyframes.
Probably we just want to remove the steps check on line 179.

[loyso (OOO), 2014-12-19 02:50:23]

https://codereview.chromium.org/812013002/diff/1/ManualTests/animation/compos...
File ManualTests/animation/compositor-animation-steps.html (right):

https://codereview.chromium.org/812013002/diff/1/ManualTests/animation/compos...
ManualTests/animation/compositor-animation-steps.html:32: var transformKeyframes
= [
On 2014/12/19 at 02:00:55, dstockwell wrote:
> nit: no need to indent this script

Ok. That was inspired by compositor-animation-playback-rate.html and
compositor-animation-playback-rate-reverse.html
We should fix the indent there as well! :) (later)

[loyso (OOO), 2014-12-22 07:00:54]

https://codereview.chromium.org/812013002/diff/1/Source/core/animation/Compos...
File Source/core/animation/CompositorAnimations.cpp (right):

https://codereview.chromium.org/812013002/diff/1/Source/core/animation/Compos...
Source/core/animation/CompositorAnimations.cpp:182: if
(timing.timingFunction->type() == TimingFunction::StepsFunction)
On 2014/12/19 at 02:00:55, dstockwell wrote:
> I think this isn't quite right, as the comment below indicates that the
combining of timing functions is only supported when there are 2 keyframes.
Probably we just want to remove the steps check on line 179.

That wasn't right, indeed. Fixed.

[dstockwell, 2014-12-29 02:05:23]

lgtm

[loyso (OOO), 2014-12-29 03:05:38]

loyso@chromium.org changed reviewers:
+ vollick@chromium.org

[loyso (OOO), 2015-01-02 03:57:16]

On 2014/12/29 at 03:05:38, loyso wrote:
> loyso@chromium.org changed reviewers:
> + vollick@chromium.org

PTAL, anyone! I have more dependent CLs to go.

[ajuma, 2015-01-02 15:42:37]

On 2015/01/02 03:57:16, loyso wrote:
> On 2014/12/29 at 03:05:38, loyso wrote:
> > mailto:loyso@chromium.org changed reviewers:
> > + mailto:vollick@chromium.org
> 
> PTAL, anyone! I have more dependent CLs to go.

Non-OWNER lgtm.

[Ian Vollick, 2015-01-02 16:47:19]

On 2015/01/02 15:42:37, ajuma (OOO till Jan. 5) wrote:
> On 2015/01/02 03:57:16, loyso wrote:
> > On 2014/12/29 at 03:05:38, loyso wrote:
> > > mailto:loyso@chromium.org changed reviewers:
> > > + mailto:vollick@chromium.org
> > 
> > PTAL, anyone! I have more dependent CLs to go.
> 
> Non-OWNER lgtm.

lgtm, but I'm not an owner in public/platform, either.

[loyso (OOO), 2015-01-04 23:35:33]

loyso@chromium.org changed reviewers:
+ pfeldman@chromium.org, tkent@chromium.org

[loyso (OOO), 2015-01-04 23:35:33]

pfeldman@chromium.org: Please review changes in 

tkent@chromium.org: Please review changes in

[loyso (OOO), 2015-01-04 23:37:04]

loyso@chromium.org changed reviewers:
+ japhet@chromium.org
- tkent@chromium.org

[loyso (OOO), 2015-01-06 03:47:41]

loyso@chromium.org changed reviewers:
+ dglazkov@chromium.org

[loyso (OOO), 2015-01-06 03:50:23]

On 2015/01/04 23:35:33, loyso wrote:
> mailto:pfeldman@chromium.org: Please review changes in 
> 
> mailto:tkent@chromium.org: Please review changes in

I've added three reviewers from public/platform/OWNERS but I need just one
approval. Anyone, please? :)

[dglazkov, 2015-01-06 04:24:45]

LGTM LGTM LGTM

[loyso (OOO), 2015-01-06 04:29:40]

The CQ bit was checked by loyso@chromium.org

[commit-bot: I haz the power, 2015-01-06 04:29:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/812013002/20001

[commit-bot: I haz the power, 2015-01-06 04:33:38]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187891