Define step timing function for the cc animation framework.

Source/core/animation/CompositorAnimations.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 127 matching lines @@
     const KeyframeEffectModelBase& keyframeEffect = toKeyframeEffectModelBase(effect);
 
     PropertySet properties = keyframeEffect.properties();
 
     if (properties.isEmpty())
         return false;
 
     for (const auto& property : properties) {
         const PropertySpecificKeyframeVector& keyframes = keyframeEffect.getPropertySpecificKeyframes(property);
         ASSERT(keyframes.size() >= 2);
-        auto* lastKeyframe = keyframes.last().get();
         for (const auto& keyframe : keyframes) {
             // FIXME: Determine candidacy based on the CSSValue instead of a snapshot AnimatableValue.
             if (keyframe->composite() != AnimationEffect::CompositeReplace || !keyframe->getAnimatableValue())
                 return false;
 
             switch (property) {
             case CSSPropertyOpacity:
                 break;
             case CSSPropertyTransform:
                 if (toAnimatableTransform(keyframe->getAnimatableValue().get())->transformOperations().dependsOnBoxSize())
                     return false;
                 break;
             case CSSPropertyWebkitFilter: {
                 const FilterOperations& operations = toAnimatableFilterOperations(keyframe->getAnimatableValue().get())->operations();
                 if (operations.hasFilterThatMovesPixels())
                     return false;
                 break;
             }
             default:
                 return false;
             }
-
-            // FIXME: Remove this check when crbug.com/229405 is resolved
-            if (keyframe != lastKeyframe && keyframe->easing().type() == TimingFunction::StepsFunction)
-                return false;
         }
     }
 
     CompositorAnimationsImpl::CompositorTiming out;
     if (!CompositorAnimationsImpl::convertTimingForCompositor(timing, 0, out, playerPlaybackRate))
         return false;
 
     if (timing.timingFunction->type() != TimingFunction::LinearFunction) {
         // Checks the of size of KeyframeVector instead of PropertySpecificKeyframeVector.
         const KeyframeVector& keyframes = keyframeEffect.getFrames();
         if (keyframes.size() == 2 && keyframes.first()->easing().type() == TimingFunction::LinearFunction && timing.timingFunction->type() != TimingFunction::StepsFunction)
             return true;
 
+        if (timing.timingFunction->type() == TimingFunction::StepsFunction)

[dstockwell, 2014/12/19 02:00:55]

I think this isn't quite right, as the comment below indicates that the
combining of timing functions is only supported when there are 2 keyframes.
Probably we just want to remove the steps check on line 179.

[loyso (OOO), 2014/12/22 07:00:54]

That wasn't right, indeed. Fixed.

+            return true;
+
         // FIXME: Support non-linear timing functions in the compositor for
         // more than two keyframes and step timing functions in the compositor.
         return false;
     }
 
     return true;
 }
 
 bool CompositorAnimations::canStartAnimationOnCompositor(const Element& element)
 {
@@ skipping 126 matching lines @@
                 ASSERT_NOT_REACHED();
                 return;
             }
 
             curve.add(keyframe, easeType);
         }
         return;
     }
 
     case TimingFunction::StepsFunction:
-    default:
-        ASSERT_NOT_REACHED();
+        const StepsTimingFunction* steps = toStepsTimingFunction(timingFunction);
+
+        float stepsStartOffset;
+        switch (steps->stepAtPosition()) {
+        case StepsTimingFunction::Start:
+            stepsStartOffset = 1;
+            break;
+        case StepsTimingFunction::Middle:
+            stepsStartOffset = 0.5;
+            break;
+        case StepsTimingFunction::End:
+            stepsStartOffset = 0;
+            break;
+        default:
+            ASSERT_NOT_REACHED();
+            return;
+        }
+        curve.add(keyframe, steps->numberOfSteps(), stepsStartOffset);
         return;
     }
 }
 
 } // namespace anoymous
 
 void CompositorAnimationsImpl::addKeyframesToCurve(WebCompositorAnimationCurve& curve, const PropertySpecificKeyframeVector& keyframes, const Timing& timing)
 {
     auto* lastKeyframe = keyframes.last().get();
     for (const auto& keyframe : keyframes) {
@@ skipping 127 matching lines @@
             break;
         default:
             ASSERT_NOT_REACHED();
         }
         animations.append(animation.release());
     }
     ASSERT(!animations.isEmpty());
 }
 
 } // namespace blink