Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 81193003: [Sync] Don't DCHECK if we can't find the window for a tab (Closed)

Created:
7 years, 1 month ago by Nicolas Zea
Modified:
7 years ago
Reviewers:
haitaol1
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org
Visibility:
Public.

Description

[Sync] Don't DCHECK if we can't find the window for a tab If the model association happens at the right time (i.e. when a tab is being dragged from one window to another), the tab strip model may be out of date. Just handle this gracefully for now and return false. BUG=282590 TBR=haitao@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238338

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/sync/browser_synced_window_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nicolas Zea
PTAL
7 years, 1 month ago (2013-11-21 19:09:28 UTC) #1
haitaol1
lgtm
7 years ago (2013-11-25 17:27:25 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years ago (2013-12-02 19:57:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/81193003/1
7 years ago (2013-12-02 20:55:38 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-03 10:38:13 UTC) #5
Message was sent while issue was closed.
Change committed as 238338

Powered by Google App Engine
This is Rietveld 408576698