Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7008)

Unified Diff: chrome/browser/ui/sync/browser_synced_window_delegate.cc

Issue 81193003: [Sync] Don't DCHECK if we can't find the window for a tab (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/sync/browser_synced_window_delegate.cc
diff --git a/chrome/browser/ui/sync/browser_synced_window_delegate.cc b/chrome/browser/ui/sync/browser_synced_window_delegate.cc
index 7809aa006af612b6aa1743b45649eb35e046b486..2057582f86a38b78f556472da95cfe2adea9365b 100644
--- a/chrome/browser/ui/sync/browser_synced_window_delegate.cc
+++ b/chrome/browser/ui/sync/browser_synced_window_delegate.cc
@@ -47,7 +47,8 @@ bool BrowserSyncedWindowDelegate::IsTabPinned(
if (tab == current)
return browser_->tab_strip_model()->IsTabPinned(i);
}
- NOTREACHED();
+ // The window and tab are not always updated atomically, so it's possible
+ // one of the values was stale. We'll retry later, just ignore for now.
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698