Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 811673002: Remove dependency on Jingle-specific files. We don't use them anymore, and the files are going awa…

Created:
6 years ago by pthatcher2
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency on Jingle-specific files. We don't use them anymore, and the files are going away soon. Note that we can't submit this file until https://webrtc-codereview.appspot.com/35529004/ is submitted and rolled into Chromium. Otherwise, the Jingle-specific pieces in session.cc will cause Chromium with this CL to not link. Also note that we can't move all of the Jingle-specific files out of WebRTC until this CL is submitted. Otherwise, Chromium would fail to compile.

Patch Set 1 #

Patch Set 2 : chromium-remove-last-of-jingle #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M third_party/libjingle/libjingle_common.gypi View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pthatcher2
6 years ago (2014-12-16 05:03:34 UTC) #2
pbos
lgtm if it still builds
6 years ago (2014-12-16 19:20:36 UTC) #3
pthatcher2
On 2014/12/16 19:20:36, pbos wrote: > lgtm if it still builds As noted in the ...
6 years ago (2014-12-16 19:38:53 UTC) #4
Dr Alex
5 years, 11 months ago (2015-01-14 15:28:01 UTC) #5
On 2014/12/16 19:38:53, pthatcher2 wrote:
> On 2014/12/16 19:20:36, pbos wrote:
> > lgtm if it still builds
> 
> As noted in the description, I won't submit until
> https://webrtc-codereview.appspot.com/35529004/ is submitted and rolled.

it was committed: https://code.google.com/p/webrtc/source/detail?r=7922

Powered by Google App Engine
This is Rietveld 408576698