Test rendering of non-integer border-image-width values

Test rendering of non-integer border-image-width values

Compare computed non-integer border-image-width values with the
rendering of the respective computed border-width value.

BUG=318081
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162635

[eseidel, 2013-11-21 16:08:13]

Is this obserable via getComputedStyle?  Is it easier to write a text-based test
than a ref test for this?

[davve, 2013-11-22 07:57:37]

On 2013/11/21 16:08:13, eseidel wrote:
> Is this obserable via getComputedStyle?  Is it easier to write a text-based
test
> than a ref test for this?

No, the actual rendered value is not observable by getComputedStyle. The
rendered value is computed during paint, in
RenderBoxModelObject::paintNinePieceImage, where we go from border width as a
LayoutUnit to an int. See tests in https://codereview.chromium.org/54383006 and
specifically https://codereview.chromium.org/54383006/#msg3 for why I add this
specific test.

[davve, 2013-11-22 11:57:55]

On 2013/11/22 07:57:37, David Vest wrote:
> On 2013/11/21 16:08:13, eseidel wrote:
> > Is this obserable via getComputedStyle?  Is it easier to write a text-based
> test
> > than a ref test for this?
> 
> No, the actual rendered value is not observable by getComputedStyle.

I've updated the description to make it clearer what we want to test.

[Julien - ping for review, 2013-11-25 07:29:09]

lgtm with some comments.

Also let's wrap your description at 80 or less columns. The ideal number from
(see
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/rqGhY7PfkYY)
was 72 columns, which is what git cl upload advises.

https://codereview.chromium.org/81163002/diff/1/LayoutTests/fast/borders/bord...
File LayoutTests/fast/borders/border-image-width-rounding.html (right):

https://codereview.chromium.org/81163002/diff/1/LayoutTests/fast/borders/bord...
LayoutTests/fast/borders/border-image-width-rounding.html:5: as
border-width</title>
My usual comment about <title>, if it's important enough to be included in the
test, it should be dumped in the output unless it ties the test to a platform.

https://codereview.chromium.org/81163002/diff/1/LayoutTests/fast/borders/bord...
LayoutTests/fast/borders/border-image-width-rounding.html:17: </head>
Let's include a description (the <title> content would cover that well) and what
we expect for the test to pass (e.g. "There should be a green border around a
100x100 square below").

[commit-bot: I haz the power, 2013-11-25 17:42:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davve@opera.com/81163002/90001

[commit-bot: I haz the power, 2013-11-25 19:28:56]

Change committed as 162635