Issue 54383006: Lift integer restriction on border-image-width and border-image-outset

Issue 54383006: Lift integer restriction on border-image-width and border-image-outset (Closed)

Created:
7 years, 1 month ago by davve

Modified:
7 years, 1 month ago

Reviewers:
Julien - ping for review

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@length-relative-die-step-4-4

Visibility:
Public.

More Reviews

Description

Lift integer restriction on border-image-width and border-image-outset border-image-{width,outset} should accept percentages, lengths, numbers, and auto. A number represents a multiple of the computed border-width, and should not be restricted to integral values. BUG=304000 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161807

Patch Set 1 #

Patch Set 2 : Rebase and simplify test #

Total comments: 6

Patch Set 3 : Re-added reftest to test rendering #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+81 lines, -6 lines)			Patch
A	LayoutTests/fast/borders/border-image-width-numbers.html	View	1 2	1 chunk	+29 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/borders/border-image-width-numbers-computed-style.html	View	1 2	1 chunk	+23 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/borders/border-image-width-numbers-computed-style-expected.txt	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/borders/border-image-width-numbers-expected.html	View	1 2	1 chunk	+17 lines, -0 lines	0 comments	Download
M	Source/core/css/CSSParser-in.cpp	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSToStyleMap.cpp	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

davve

On 2013/11/01 14:23:18, David Vest wrote: > Written on top of the Length/LengthOrNumber refactoring. The ...

7 years, 1 month ago (2013-11-11 13:29:33 UTC) #2

Julien - ping for review

lgtm https://codereview.chromium.org/54383006/diff/50001/LayoutTests/fast/borders/border-image-width-numbers-computed-style.html File LayoutTests/fast/borders/border-image-width-numbers-computed-style.html (right): https://codereview.chromium.org/54383006/diff/50001/LayoutTests/fast/borders/border-image-width-numbers-computed-style.html#newcode14 LayoutTests/fast/borders/border-image-width-numbers-computed-style.html:14: <body> There should be a description of what ...

7 years, 1 month ago (2013-11-12 00:34:00 UTC) #3

davve

https://codereview.chromium.org/54383006/diff/50001/LayoutTests/fast/borders/border-image-width-numbers-computed-style.html File LayoutTests/fast/borders/border-image-width-numbers-computed-style.html (right): https://codereview.chromium.org/54383006/diff/50001/LayoutTests/fast/borders/border-image-width-numbers-computed-style.html#newcode14 LayoutTests/fast/borders/border-image-width-numbers-computed-style.html:14: <body> On 2013/11/12 00:34:00, Julien Chaffraix - AEDT wrote: ...

7 years, 1 month ago (2013-11-12 10:47:05 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/54383006/120001

7 years, 1 month ago (2013-11-12 10:47:30 UTC) #5

commit-bot: I haz the power

Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=12201

7 years, 1 month ago (2013-11-12 12:43:08 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davve@opera.com/54383006/120001

7 years, 1 month ago (2013-11-12 12:48:52 UTC) #7

Message was sent while issue was closed.

Change committed as 161807

Expand Messages | Collapse Messages