Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 811623005: Refactoring DevToolsBridgeServer. (Closed)

Created:
6 years ago by SeRya
Modified:
6 years ago
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring DevToolsBridgeServer. After prototyping integration of DevToolsBridgeServer into Clank there are several fixed found needed: 1. Remove UI and service lifetime management from DevToolsBridgeServer. While it causes some duplication in tests it makes UI much more flexible. Lifetime is easier to understand when places closer to context. 2. Decouple DevToolsBridgeServer from Service. It makes testing simpler. 3. Support for asynchronous socket resolution. Socket name in Clank may change (when service runs in a separate process) and name resolution involves IO. BUG=383418 Committed: https://crrev.com/7cd18625ce3d1ad965edf6798871499e589242b6 Cr-Commit-Position: refs/heads/master@{#308802}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+433 lines, -417 lines) Patch
M components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/DevToolsBridgeServer.java View 6 chunks +67 lines, -119 lines 0 comments Download
M components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/DevToolsBridgeServiceBase.java View 1 5 chunks +80 lines, -7 lines 0 comments Download
M components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/GCDNotificationHandler.java View 3 chunks +31 lines, -7 lines 0 comments Download
A components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/ServiceLifetimeManager.java View 1 chunk +83 lines, -0 lines 0 comments Download
M components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/apiary/GCDClient.java View 1 chunk +10 lines, -0 lines 0 comments Download
M components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/gcd/MessageWriter.java View 1 chunk +13 lines, -0 lines 0 comments Download
D components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/ui/ServiceUIFactory.java View 1 chunk +0 lines, -43 lines 0 comments Download
M components/devtools_bridge/android/javatests/AndroidManifest.xml View 1 chunk +0 lines, -4 lines 0 comments Download
M components/devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/DevToolsBridgeServerTest.java View 2 chunks +34 lines, -36 lines 0 comments Download
M components/devtools_bridge/android/javatests/src/org/chromium/components/devtools_bridge/tests/DebugActivity.java View 1 chunk +1 line, -1 line 0 comments Download
M components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/ClientSessionTestingHost.java View 1 3 chunks +7 lines, -2 lines 0 comments Download
M components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/DevToolsBridgeServerSandbox.java View 1 3 chunks +52 lines, -65 lines 0 comments Download
D components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/LocalBindingTestService.java View 1 chunk +0 lines, -122 lines 0 comments Download
M components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/TestDevToolsBridgeService.java View 2 chunks +55 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
SeRya
PTAL
6 years ago (2014-12-17 13:40:41 UTC) #3
mnaganov (inactive)
LGTM https://codereview.chromium.org/811623005/diff/20001/components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/DevToolsBridgeServiceBase.java File components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/DevToolsBridgeServiceBase.java (right): https://codereview.chromium.org/811623005/diff/20001/components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/DevToolsBridgeServiceBase.java#newcode101 components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/DevToolsBridgeServiceBase.java:101: * Unkike similar method in IntentService this one ...
6 years ago (2014-12-17 15:56:43 UTC) #4
SeRya
https://codereview.chromium.org/811623005/diff/20001/components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/DevToolsBridgeServiceBase.java File components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/DevToolsBridgeServiceBase.java (right): https://codereview.chromium.org/811623005/diff/20001/components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/DevToolsBridgeServiceBase.java#newcode101 components/devtools_bridge/android/java/src/org/chromium/components/devtools_bridge/DevToolsBridgeServiceBase.java:101: * Unkike similar method in IntentService this one runs ...
6 years ago (2014-12-17 16:03:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811623005/40001
6 years ago (2014-12-17 16:04:45 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years ago (2014-12-17 17:19:40 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-17 17:25:17 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7cd18625ce3d1ad965edf6798871499e589242b6
Cr-Commit-Position: refs/heads/master@{#308802}

Powered by Google App Engine
This is Rietveld 408576698