Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/ClientSessionTestingHost.java

Issue 811623005: Refactoring DevToolsBridgeServer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/ClientSessionTestingHost.java
diff --git a/components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/ClientSessionTestingHost.java b/components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/ClientSessionTestingHost.java
index 39663e6f0d9b372c4df878ab0935c2ee0ecb69ec..441353a8f0f24a86884035b0bbdf1614cba4adab 100644
--- a/components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/ClientSessionTestingHost.java
+++ b/components/devtools_bridge/test/android/javatests/src/org/chromium/components/devtools_bridge/ClientSessionTestingHost.java
@@ -15,7 +15,6 @@ import java.io.IOException;
*/
public class ClientSessionTestingHost {
private static final String TAG = "ClientSessionTestingHost";
- private static final String SESSION_ID = "ID";
private final SignalingReceiver mTarget;
private final SessionBase.Executor mTargetExecutor;
@@ -40,7 +39,7 @@ public class ClientSessionTestingHost {
mClientSession = new ClientSession(
factory,
mClientExecutor,
- proxy.asServerSession(SESSION_ID),
+ proxy.asServerSession(mSessionId),
clientSocketName) {
@Override
protected void closeSelf() {
@@ -59,6 +58,12 @@ public class ClientSessionTestingHost {
Log.d(TAG, "Control channel closed");
super.onControlChannelClosed();
}
+
+ @Override
+ protected void onFailure(String message) {
+ Log.e(TAG, "Failure: " + message);
+ super.onFailure(message);
+ }
};
}

Powered by Google App Engine
This is Rietveld 408576698