Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: build/config/compiler/BUILD.gn

Issue 811163003: GN: remove clang flag for NaCl build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index c221ddd327a4a033c612fc41ca981f47c12418a9..dcd5d6596d619d40e2389f20f7fee94cdd351694 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -762,10 +762,18 @@ config("default_warnings") {
# TODO(thakis): Remove, http://crbug.com/263960
"-Wno-reserved-user-defined-literal",
-
- # TODO(hans): Get this cleaned up.
- "-Wno-inconsistent-missing-override",
]
+
+ # NaCl's Clang compiler and Chrome's hermetic Clang compiler will almost
+ # always have different versions. Certain flags may not be recognized by
+ # one version or the other.
+ if (!is_nacl) {
+ # Flags NaCl does not recognize.
+ cflags += [
+ # TODO(hans): Get this cleaned up.
+ "-Wno-inconsistent-missing-override",
+ ]
+ }
}
if (gcc_version >= 48) {
cflags_cc += [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698