Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 811163003: GN: remove clang flag for NaCl build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 if (cpu_arch == "arm") { 6 if (cpu_arch == "arm") {
7 import("//build/config/arm.gni") 7 import("//build/config/arm.gni")
8 } 8 }
9 if (is_posix) { 9 if (is_posix) {
10 import("//build/config/gcc/gcc_version.gni") 10 import("//build/config/gcc/gcc_version.gni")
(...skipping 744 matching lines...) Expand 10 before | Expand all | Expand 10 after
755 # http://crbug.com/255186 755 # http://crbug.com/255186
756 "-Wno-deprecated-register", 756 "-Wno-deprecated-register",
757 757
758 # TODO(thakis): This used to be implied by -Wno-unused-function, 758 # TODO(thakis): This used to be implied by -Wno-unused-function,
759 # which we no longer use. Check if it makes sense to remove 759 # which we no longer use. Check if it makes sense to remove
760 # this as well. http://crbug.com/316352 760 # this as well. http://crbug.com/316352
761 "-Wno-unneeded-internal-declaration", 761 "-Wno-unneeded-internal-declaration",
762 762
763 # TODO(thakis): Remove, http://crbug.com/263960 763 # TODO(thakis): Remove, http://crbug.com/263960
764 "-Wno-reserved-user-defined-literal", 764 "-Wno-reserved-user-defined-literal",
765 ]
765 766
766 # TODO(hans): Get this cleaned up. 767 # NaCl's Clang compiler and Chrome's hermetic Clang compiler will almost
767 "-Wno-inconsistent-missing-override", 768 # always have different versions. Certain flags may not be recognized by
768 ] 769 # one version or the other.
770 if (!is_nacl) {
771 # Flags NaCl does not recognize.
772 cflags += [
773 # TODO(hans): Get this cleaned up.
774 "-Wno-inconsistent-missing-override",
775 ]
776 }
769 } 777 }
770 if (gcc_version >= 48) { 778 if (gcc_version >= 48) {
771 cflags_cc += [ 779 cflags_cc += [
772 # See comment for -Wno-c++11-narrowing. 780 # See comment for -Wno-c++11-narrowing.
773 "-Wno-narrowing", 781 "-Wno-narrowing",
774 782
775 # TODO(thakis): Remove, http://crbug.com/263960 783 # TODO(thakis): Remove, http://crbug.com/263960
776 "-Wno-literal-suffix", 784 "-Wno-literal-suffix",
777 ] 785 ]
778 } 786 }
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
979 cflags += [ "-gsplit-dwarf" ] 987 cflags += [ "-gsplit-dwarf" ]
980 } 988 }
981 } 989 }
982 } 990 }
983 991
984 config("no_symbols") { 992 config("no_symbols") {
985 if (!is_win) { 993 if (!is_win) {
986 cflags = [ "-g0" ] 994 cflags = [ "-g0" ]
987 } 995 }
988 } 996 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698