Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 811163003: GN: remove clang flag for NaCl build. (Closed)

Created:
6 years ago by Nick Bray (chromium)
Modified:
6 years ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: remove clang flag for NaCl build. NaCl's version of clang is slightly older than the hermetic version used in Chrome, and does not support this flag. NaCl's GN build is not live in the Chrome tree, yet, but this flag breaks local work to bring it up. BUG=https://code.google.com/p/chromium/issues/detail?id=401761 Committed: https://crrev.com/395afdd8d2cb172a0003816d33eb5ec785ea2aa7 Cr-Commit-Position: refs/heads/master@{#308870}

Patch Set 1 #

Patch Set 2 : Comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M build/config/compiler/BUILD.gn View 1 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Nick Bray (chromium)
6 years ago (2014-12-17 20:48:14 UTC) #2
Nick Bray (chromium)
+brettw, don't know if Dirk is in today.
6 years ago (2014-12-17 20:49:25 UTC) #4
brettw
Can you add the comment like in the CL description to the flag? It's not ...
6 years ago (2014-12-17 21:03:22 UTC) #5
Dirk Pranke
On 2014/12/17 21:03:22, brettw wrote: > Can you add the comment like in the CL ...
6 years ago (2014-12-17 21:20:53 UTC) #6
Nick Bray (chromium)
PTAL
6 years ago (2014-12-17 21:50:12 UTC) #7
Dirk Pranke
lgtm
6 years ago (2014-12-17 21:53:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/811163003/20001
6 years ago (2014-12-17 22:02:00 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-17 22:56:42 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-17 22:58:28 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/395afdd8d2cb172a0003816d33eb5ec785ea2aa7
Cr-Commit-Position: refs/heads/master@{#308870}

Powered by Google App Engine
This is Rietveld 408576698