Issue 811143002: Auto-rebaseline for r187299

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 811143002: Auto-rebaseline for r187299 (Closed)

Created:
6 years ago by Xianzhu

Modified:
6 years ago

Reviewers:
jianli, alancutter (OOO until 2018)

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Auto-rebaseline for r187299 http://src.chromium.org/viewvc/blink?view=revision&revision=187299 BUG=381919 TBR=jianli@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187388

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	LayoutTests/TestExpectations	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Xianzhu

Committed patchset #1 (id:1) manually as 187388 (presubmit successful).

6 years ago (2014-12-17 17:30:26 UTC) #1

Xianzhu

Sorry, this autorebaseline is still incorrect, but we need to commit it to let autorebaseline ...

6 years ago (2014-12-17 17:35:33 UTC) #3

Xianzhu

6 years ago (2014-12-17 23:27:07 UTC) #4

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/784283005/ by wangxianzhu@chromium.org.

The reason for reverting is: We need to rebaseline this again together with the
base test (marked NeedsRebaseline in
http://src.chromium.org/viewvc/blink?view=rev&rev=187403)..

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages