Fix for PDF menu should not come when mouse pointer is on the scrollbar.

Fix for PDF menu should not come when mouse pointer is on the scroll bar.

PDF menu comes when mouse came in the PDF menu rect.
Changes done to stop call to handle event by toolbar when mouse pointer is on any of the scroll bar.

BUG=80214
Committed: https://crrev.com/7beb4d065878883bfadcfa161c03af696a528096
Cr-Commit-Position: refs/heads/master@{#310444}

[Deepak, 2014-12-31 06:52:33]

deepak.m1@samsung.com changed reviewers:
+ gene@chromium.org, raymes@chromium.org

[Deepak, 2014-12-31 06:52:34]

PTAL at my changes.
Thanks

[Deepak, 2015-01-05 11:30:03]

On 2014/12/31 06:52:34, Deepak wrote:
> PTAL at my changes.
> Thanks

This issue is not present in the OOP case.

[gene, 2015-01-05 21:51:32]

https://codereview.chromium.org/811083004/diff/40001/pdf/instance.cc
File pdf/instance.cc (right):

https://codereview.chromium.org/811083004/diff/40001/pdf/instance.cc#newcode1602
pdf/instance.cc:1602: bool Instance::IsMouseOnScrollbar(const pp::InputEvent&
event) {
It probably make sense to accept mouse events only (const pp::MouseInputEvent&
mouse_event) or check conversion from InputEvent to MouseInputEvent two lines
below.

[Deepak, 2015-01-06 09:20:32]

Changes done as suggested.
PTAL.
Thanks

https://codereview.chromium.org/811083004/diff/40001/pdf/instance.cc
File pdf/instance.cc (right):

https://codereview.chromium.org/811083004/diff/40001/pdf/instance.cc#newcode1602
pdf/instance.cc:1602: bool Instance::IsMouseOnScrollbar(const pp::InputEvent&
event) {
On 2015/01/05 21:51:32, gene wrote:
> It probably make sense to accept mouse events only (const pp::MouseInputEvent&
> mouse_event) or check conversion from InputEvent to MouseInputEvent two lines
> below.

Thanks for review.
I agree with you,as we are not sure about event_device_res type, so I am putting
check for MouseInputEvent here.
Thanks

[gene, 2015-01-08 00:26:38]

lgtm

[Deepak, 2015-01-08 01:37:11]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2015-01-08 01:37:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/811083004/60001

[commit-bot: I haz the power, 2015-01-08 02:34:27]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-08 02:35:15]

Patchset 4 (id:??) landed as
https://crrev.com/7beb4d065878883bfadcfa161c03af696a528096
Cr-Commit-Position: refs/heads/master@{#310444}