Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: pdf/instance.h

Issue 811083004: Fix for PDF menu should not come when mouse pointer is on the scrollbar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes as per review comments. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pdf/instance.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PDF_INSTANCE_H_ 5 #ifndef PDF_INSTANCE_H_
6 #define PDF_INSTANCE_H_ 6 #define PDF_INSTANCE_H_
7 7
8 #include <queue> 8 #include <queue>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 pp::Var* exception); 193 pp::Var* exception);
194 194
195 // PreviewModeClient::Client implementation. 195 // PreviewModeClient::Client implementation.
196 virtual void PreviewDocumentLoadComplete() override; 196 virtual void PreviewDocumentLoadComplete() override;
197 virtual void PreviewDocumentLoadFailed() override; 197 virtual void PreviewDocumentLoadFailed() override;
198 198
199 // Helper functions for implementing PPP_PDF. 199 // Helper functions for implementing PPP_PDF.
200 void RotateClockwise(); 200 void RotateClockwise();
201 void RotateCounterclockwise(); 201 void RotateCounterclockwise();
202 202
203 // Helper function to inform when mouse pointer is on scrollbar, returns true
204 // when mouse is on vertical or horizaontal scrollbar else returns false.
205 bool IsMouseOnScrollbar(const pp::InputEvent& event);
206
203 private: 207 private:
204 // Called whenever the plugin geometry changes to update the location of the 208 // Called whenever the plugin geometry changes to update the location of the
205 // scrollbars, background parts, and notifies the pdf engine. 209 // scrollbars, background parts, and notifies the pdf engine.
206 void OnGeometryChanged(double old_zoom, float old_device_scale); 210 void OnGeometryChanged(double old_zoom, float old_device_scale);
207 211
208 // Runs the given JS callback given in |callback|. 212 // Runs the given JS callback given in |callback|.
209 void RunCallback(int32_t, pp::Var callback); 213 void RunCallback(int32_t, pp::Var callback);
210 214
211 void CreateHorizontalScrollbar(); 215 void CreateHorizontalScrollbar();
212 void CreateVerticalScrollbar(); 216 void CreateVerticalScrollbar();
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
525 const std::vector<pp::Var>& args, 529 const std::vector<pp::Var>& args,
526 pp::Var* exception); 530 pp::Var* exception);
527 531
528 private: 532 private:
529 Instance* instance_; 533 Instance* instance_;
530 }; 534 };
531 535
532 } // namespace chrome_pdf 536 } // namespace chrome_pdf
533 537
534 #endif // PDF_INSTANCE_H_ 538 #endif // PDF_INSTANCE_H_
OLDNEW
« no previous file with comments | « no previous file | pdf/instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698