Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2782)

Unified Diff: build/common.gypi

Issue 811083003: Only use /Gw in non-ASan builds on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improve the comment Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index d1492320f727797ac8f4fb5c39ea091aba0eacf6..bf3e7785d935cf81520a2102d362b43463fc221f 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3372,11 +3372,18 @@
# "/Oy /Oy-" and warnings about overriding.
'AdditionalOptions': ['/Oy-'],
}],
+ ['asan==0', {
+ # Put data in separate COMDATs. This allows the linker
+ # to put bit-identical constants at the same address even if
+ # they're unrelated constants, which saves binary size.
+ # This optimization can't be used when ASan is enabled because
+ # it is not compatible with the ASan ODR checker.
+ 'AdditionalOptions': ['/Gw'],
+ }],
],
'AdditionalOptions': [
'/d2Zi+', # Improve debugging of Release builds.
'/Zc:inline', # Remove unreferenced COMDAT (faster links).
- '/Gw', # Put data in separate COMDATs.
'<@(win_release_extra_cflags)',
],
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698