Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: build/common.gypi

Issue 811083003: Only use /Gw in non-ASan builds on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Improve the comment Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 3354 matching lines...) Expand 10 before | Expand all | Expand 10 after
3365 }], 3365 }],
3366 ['win_release_OmitFramePointers==0', { 3366 ['win_release_OmitFramePointers==0', {
3367 'OmitFramePointers': 'false', 3367 'OmitFramePointers': 'false',
3368 # The above is not sufficient (http://crbug.com/106711): it 3368 # The above is not sufficient (http://crbug.com/106711): it
3369 # simply eliminates an explicit "/Oy", but both /O2 and /Ox 3369 # simply eliminates an explicit "/Oy", but both /O2 and /Ox
3370 # perform FPO regardless, so we must explicitly disable. 3370 # perform FPO regardless, so we must explicitly disable.
3371 # We still want the false setting above to avoid having 3371 # We still want the false setting above to avoid having
3372 # "/Oy /Oy-" and warnings about overriding. 3372 # "/Oy /Oy-" and warnings about overriding.
3373 'AdditionalOptions': ['/Oy-'], 3373 'AdditionalOptions': ['/Oy-'],
3374 }], 3374 }],
3375 ['asan==0', {
3376 # Put data in separate COMDATs. This allows the linker
3377 # to put bit-identical constants at the same address even if
3378 # they're unrelated constants, which saves binary size.
3379 # This optimization can't be used when ASan is enabled because
3380 # it is not compatible with the ASan ODR checker.
3381 'AdditionalOptions': ['/Gw'],
3382 }],
3375 ], 3383 ],
3376 'AdditionalOptions': [ 3384 'AdditionalOptions': [
3377 '/d2Zi+', # Improve debugging of Release builds. 3385 '/d2Zi+', # Improve debugging of Release builds.
3378 '/Zc:inline', # Remove unreferenced COMDAT (faster links). 3386 '/Zc:inline', # Remove unreferenced COMDAT (faster links).
3379 '/Gw', # Put data in separate COMDATs.
3380 '<@(win_release_extra_cflags)', 3387 '<@(win_release_extra_cflags)',
3381 ], 3388 ],
3382 }, 3389 },
3383 'VCLinkerTool': { 3390 'VCLinkerTool': {
3384 # LinkIncremental is a tri-state boolean, where 0 means default 3391 # LinkIncremental is a tri-state boolean, where 0 means default
3385 # (i.e., inherit from parent solution), 1 means false, and 3392 # (i.e., inherit from parent solution), 1 means false, and
3386 # 2 means true. 3393 # 2 means true.
3387 'LinkIncremental': '1', 3394 'LinkIncremental': '1',
3388 # This corresponds to the /PROFILE flag which ensures the PDB 3395 # This corresponds to the /PROFILE flag which ensures the PDB
3389 # file contains FIXUP information (growing the PDB file by about 3396 # file contains FIXUP information (growing the PDB file by about
(...skipping 2430 matching lines...) Expand 10 before | Expand all | Expand 10 after
5820 # settings in target dicts. SYMROOT is a special case, because many other 5827 # settings in target dicts. SYMROOT is a special case, because many other
5821 # Xcode variables depend on it, including variables such as 5828 # Xcode variables depend on it, including variables such as
5822 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 5829 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
5823 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 5830 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
5824 # files to appear (when present) in the UI as actual files and not red 5831 # files to appear (when present) in the UI as actual files and not red
5825 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 5832 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
5826 # and therefore SYMROOT, needs to be set at the project level. 5833 # and therefore SYMROOT, needs to be set at the project level.
5827 'SYMROOT': '<(DEPTH)/xcodebuild', 5834 'SYMROOT': '<(DEPTH)/xcodebuild',
5828 }, 5835 },
5829 } 5836 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698