Issue 811023003: Added error check that we are on a branch when we try to upload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 811023003: Added error check that we are on a branch when we try to upload. (Closed)

Created:
6 years ago by luqui

Modified:
4 years, 4 months ago

Reviewers:
ukai, M-A Ruel, iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Target Ref:
refs/heads/master

Project:
tools

Visibility:
Public.

More Reviews

Description

Added error check that we are on a branch when we try to upload. BUG=443264

Patch Set 1 #

Patch Set 2 : Unintentional whitespace change #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	git_cl.py	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

iannucci

this feels wrong because it seems like this should be one check in a series ...

5 years, 11 months ago (2015-01-06 00:35:54 UTC) #6

M-A Ruel

5 years, 11 months ago (2015-01-06 17:13:05 UTC) #7

On 2015/01/06 00:35:54, iannucci wrote:
> this feels wrong because it seems like this should be one check in a series of
> validation checks (probably in some function).
> 
> That said, it should be strictly less bad that what we have. lgtm

no big deal, lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages