core/src/fpdfapi/fpdf_font/ttgsubtable.cpp - Issue 810883005: Fix -Wnon-virtual-dtor compiler warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_font/ttgsubtable.cpp

Issue 810883005: Fix -Wnon-virtual-dtor compiler warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Privitization where appropriate. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_font/ttgsubtable.cpp

diff --git a/core/src/fpdfapi/fpdf_font/ttgsubtable.cpp b/core/src/fpdfapi/fpdf_font/ttgsubtable.cpp

index 42f77de57bfab915e382e2700195ab16a6933300..e317aa67fd73bc3e33e01b09c9a17da9c97ed9ca 100644

--- a/core/src/fpdfapi/fpdf_font/ttgsubtable.cpp

+++ b/core/src/fpdfapi/fpdf_font/ttgsubtable.cpp

@@ -446,7 +446,7 @@ IFX_GSUBTable* FXGE_CreateGSUBTable(CFX_Font* pFont)

if (pGsubTable->m_GsubImp.LoadGSUBTable((FT_Bytes)pFont->m_pGsubData)) {

return pGsubTable;

}

- delete pGsubTable;

+ pGsubTable->Release();

brucedawson 2015/01/09 00:20:49 I guess this is one vote in favor of protected des

}

return NULL;

}