Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: core/src/fpdfapi/fpdf_font/ttgsubtable.cpp

Issue 810883005: Fix -Wnon-virtual-dtor compiler warnings. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Privitization where appropriate. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "../../../include/fxge/fx_ge.h" 7 #include "../../../include/fxge/fx_ge.h"
8 #include "../../../include/fxge/fx_freetype.h" 8 #include "../../../include/fxge/fx_freetype.h"
9 #include "ttgsubtable.h" 9 #include "ttgsubtable.h"
10 CFX_GlyphMap::CFX_GlyphMap() 10 CFX_GlyphMap::CFX_GlyphMap()
(...skipping 428 matching lines...) Expand 10 before | Expand all | Expand 10 after
439 } 439 }
440 int error = FXFT_Load_Sfnt_Table(pFont->m_Face, FT_MAKE_TAG('G', 'S', 'U', ' B'), 0, pFont->m_pGsubData, NULL); 440 int error = FXFT_Load_Sfnt_Table(pFont->m_Face, FT_MAKE_TAG('G', 'S', 'U', ' B'), 0, pFont->m_pGsubData, NULL);
441 if (!error && pFont->m_pGsubData) { 441 if (!error && pFont->m_pGsubData) {
442 CFX_GSUBTable* pGsubTable = FX_NEW CFX_GSUBTable; 442 CFX_GSUBTable* pGsubTable = FX_NEW CFX_GSUBTable;
443 if (!pGsubTable) { 443 if (!pGsubTable) {
444 return NULL; 444 return NULL;
445 } 445 }
446 if (pGsubTable->m_GsubImp.LoadGSUBTable((FT_Bytes)pFont->m_pGsubData)) { 446 if (pGsubTable->m_GsubImp.LoadGSUBTable((FT_Bytes)pFont->m_pGsubData)) {
447 return pGsubTable; 447 return pGsubTable;
448 } 448 }
449 delete pGsubTable; 449 pGsubTable->Release();
brucedawson 2015/01/09 00:20:49 I guess this is one vote in favor of protected des
450 } 450 }
451 return NULL; 451 return NULL;
452 } 452 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698