Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 810763002: ARM: check immediate overflow in branch and mov_label_offset in release mode to catch crashes earli… (Closed)

Created:
6 years ago by ulan
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ARM: check immediate overflow in branch and mov_label_offset in release mode to catch crashes earlier. BUG=chromium:440913 LOG=N Committed: https://crrev.com/13449b66231b323468487ed1525b516ff6c489df Cr-Commit-Position: refs/heads/master@{#25849}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/arm/assembler-arm.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
ulan
PTAL
6 years ago (2014-12-16 13:46:01 UTC) #2
Jakob Kummerow
lgtm
6 years ago (2014-12-16 14:03:00 UTC) #3
Erik Corry
We should keep an eye on the performance bots for this one. The ones that ...
6 years ago (2014-12-16 15:03:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810763002/1
6 years ago (2014-12-16 15:07:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-16 15:35:34 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/13449b66231b323468487ed1525b516ff6c489df Cr-Commit-Position: refs/heads/master@{#25849}
6 years ago (2014-12-17 10:14:27 UTC) #9
Erik Corry
Does this need to be done for arm64 too?
6 years ago (2014-12-18 14:20:25 UTC) #10
ulan
6 years ago (2014-12-18 14:25:38 UTC) #11
Message was sent while issue was closed.
On 2014/12/18 14:20:25, Erik Corry wrote:
> Does this need to be done for arm64 too?

No, arm64 uses veneers to extend branch range.

Powered by Google App Engine
This is Rietveld 408576698