Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 810563007: IDL: Add missing type-check for callback function arguments (Closed)

Created:
5 years, 11 months ago by Jens Widell
Modified:
5 years, 11 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL: Add missing type-check for callback function arguments Internally, callback function arguments are represented as ScriptValue and can thus support any value, but the bindings layer should throw a TypeError if the value isn't a function object. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188611

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -0 lines) Patch
M Source/bindings/scripts/v8_methods.py View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/bindings/tests/idls/core/TestObject.idl View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 5 chunks +64 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL This change currently only affects setTimeout/setInterval, where the missing type-checks isn't a problem, since ...
5 years, 11 months ago (2015-01-19 08:19:29 UTC) #2
haraken
LGTM
5 years, 11 months ago (2015-01-19 08:25:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/810563007/1
5 years, 11 months ago (2015-01-19 08:27:11 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 09:42:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188611

Powered by Google App Engine
This is Rietveld 408576698